FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: malloced_unique_ptr & make_malloced_unique by refack · Pull Request #23642 · nodejs/node · GitHub

/ node Public

src: malloced_unique_ptr & make_malloced_unique - #23642

Closed
refack wants to merge 1 commit into
nodejs:masterfrom
refack:add-malloced-unique-ptr
ConversationCommits (1)ChecksFiles changed
Closed

src: malloced_unique_ptr & make_malloced_unique#23642
refack wants to merge 1 commit into
nodejs:masterfrom
refack:add-malloced-unique-ptr

Conversation

refack commented Oct 13, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Alternative to #23641

malloced_unique_ptr is just a specialization of std:unique_ptr using free for deletion, and make_malloced_unique<T> is it's factory using Malloc<T>.

Ref: #23641
Ref: #23543 (review)
Ref: #23434

CI: https://ci.nodejs.org/job/node-test-pull-request/17822/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Oct 13, 2018

Copy link
Copy Markdown
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1231/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Oct 13, 2018
refack mentioned this pull request Oct 13, 2018
Closed
2 tasks
addaleax requested changes Oct 13, 2018
View reviewed changes

addaleax left a comment •
edited by fhinkel
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The crypto changes are not improving the code.

There’s value in grouping all information about a buffer in a single struct in terms of readability, maintaining less individual local variables if they would otherwise only make sense as a pair.

refack added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 13, 2018

refack commented Oct 13, 2018

Copy link
Copy Markdown
Contributor Author

if they would otherwise only make sense as a pair.

IMHO they are only loosely make sense as a pair. They are not used as a pair, and are used in association only in:
https://github.com/nodejs/node/blob/13b0bbff04545476127b6b7dbc86297b80045670/src/node_crypto.cc#L4243

The cost of pairing them together should be weight against using a non-optimal abstraction to store them together.

addaleax commented Oct 13, 2018

Copy link
Copy Markdown
Member

IMHO they are only loosely make sense as a pair

They define the bounds of array together. Semantically, they are a pair.

They are not used as a pair, and are used in association only in:

I’m not sure what you mean by “in association” – they are used together in multiple calls you are modifying here.

As for the Buffer::New() call, it might even make sense to have a utility for MallocedBuffer → JS Buffer conversion. (But … that opens another can of worms and I’d prefer not to do it at this point. Talking about embedding use cases at the collaborator summit, it might make sense for us to provide a custom memory allocation mechanism for things that end up as ArrayBuffers).

refack force-pushed the add-malloced-unique-ptr branch from 13b0bbf to a583814 Compare October 13, 2018 18:42

refack commented Oct 13, 2018

Copy link
Copy Markdown
Contributor Author

They define the bounds of array together. Semantically, they are a pair.

Yes, but as I read it they are not used together, so the cost of keeping them together outweighs the benefits.

As for the Buffer::New() call, it might even make sense to have a utility for MallocedBuffer → JS Buffer conversion. (But … that opens another can of worms and I’d prefer not to do it at this point. Talking about embedding use cases at the collaborator summit, it might make sense for us to provide a custom memory allocation mechanism for things that end up as ArrayBuffers).

Yeah it's tricky. But I do agree that if that existed it would make sense to use a Buffer-like structure all along.
ATM as I read it MallocedBuffer is used mostly for it's RAII properties...

addaleax commented Oct 13, 2018

Copy link
Copy Markdown
Member

ATM as I read it MallocedBuffer is used mostly for it's RAII properties...

It’s better than malloc()/free() because of that, yes. It’s also a sensible abstraction for buffers.

They define the bounds of array together. Semantically, they are a pair.

Yes, but as I read it they are not used together, so the cost of keeping them together outweighs the benefits.

What cost are you referring to? There’s zero runtime overhead over having two separate variables, but on the other hand, there’s readability overhead in splitting the struct up.

fhinkel suggested changes Oct 13, 2018
View reviewed changes

fhinkel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd rather we document that MallocedBuffer(T* data, size_t size) assumes that data data was allocated with malloc than delete the method.

refack force-pushed the add-malloced-unique-ptr branch from a583814 to 5bd49eb Compare October 20, 2018 21:28
refack removed the crypto Issues and PRs related to the crypto subsystem. label Oct 20, 2018

refack commented Oct 20, 2018

Copy link
Copy Markdown
Contributor Author

Reverted unrelated changes, PTAL.
CI: https://ci.nodejs.org/job/node-test-pull-request/18013/

refack self-assigned this Oct 20, 2018
refack mentioned this pull request Oct 20, 2018
Closed
3 tasks
refack closed this Dec 21, 2018
refack deleted the add-malloced-unique-ptr branch December 21, 2018 01:14
refack removed their assignment Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax requested changes
tniessen Awaiting requested review from tniessen
joyeecheung Awaiting requested review from joyeecheung
+1 more reviewer
fhinkel fhinkel requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL