FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util,console: more spec compliant util format by BridgeAR · Pull Request #23708 · nodejs/node · GitHub

/ node Public

util,console: more spec compliant util format - #23708

Closed
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:more-spec-compliant-util-format
ConversationCommits (2)ChecksFiles changed
Closed

util,console: more spec compliant util format#23708
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:more-spec-compliant-util-format

Conversation

BridgeAR commented Oct 17, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Refs: https://console.spec.whatwg.org/#formatter

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Oct 17, 2018

Copy link
Copy Markdown
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1273/pipeline

nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Oct 17, 2018
BridgeAR added wip Issues and PRs that are still a work in progress. and removed wip Issues and PRs that are still a work in progress. labels Oct 17, 2018

BridgeAR commented Oct 17, 2018

Copy link
Copy Markdown
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/17939/

vsemozhetbyt reviewed Oct 17, 2018
View reviewed changes
Comment thread doc/api/util.md Outdated
silverwind reviewed Oct 17, 2018
View reviewed changes
Comment thread doc/api/util.md Outdated
silverwind reviewed Oct 17, 2018
View reviewed changes
Comment thread lib/util.js Outdated
silverwind reviewed Oct 17, 2018
View reviewed changes
Comment thread lib/util.js Outdated
BridgeAR added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 19, 2018

Trott commented Nov 21, 2018

Copy link
Copy Markdown
Member

@BridgeAR Are you still working on this?

util,console: handle symbols as defined in the spec
baae49c 
The `console` functions rely on the `util.format()` behavior. It
did not follow the whatwg spec when it comes to symbols in combination
with the %d, %i and %f format specifiers. Using a symbol argument in
combination with one of these specifiers resulted in an error instead
of returning `'NaN'`. This is now fixed by this patch.
BridgeAR force-pushed the more-spec-compliant-util-format branch from 2409278 to baae49c Compare November 30, 2018 18:32

BridgeAR commented Nov 30, 2018

Copy link
Copy Markdown
Member Author

Rebased.

@nodejs/util PTAL

richardlau reviewed Dec 1, 2018
View reviewed changes
Comment thread test/parallel/test-util-format.js Outdated
fixup: fix typo
dcdf5c2 
Co-Authored-By: BridgeAR <ruben@bridgewater.de>

BridgeAR commented Dec 2, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/19135/
Resumed https://ci.nodejs.org/job/node-test-commit/23879/

BridgeAR commented Dec 2, 2018

Copy link
Copy Markdown
Member Author

This needs one more LG.

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 2, 2018

Trott commented Dec 3, 2018 •
edited by BridgeAR
Loading

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19140/ ✔️

BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 3, 2018
util,console: handle symbols as defined in the spec
1fe824b 
The `console` functions rely on the `util.format()` behavior. It
did not follow the whatwg spec when it comes to symbols in combination
with the %d, %i and %f format specifiers. Using a symbol argument in
combination with one of these specifiers resulted in an error instead
of returning `'NaN'`. This is now fixed by this patch.

PR-URL: nodejs#23708
Refs: https://console.spec.whatwg.org/#formatter
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BridgeAR commented Dec 3, 2018

Copy link
Copy Markdown
Member Author

Landed in 1fe824b 🎉

BridgeAR closed this Dec 3, 2018
joyeecheung mentioned this pull request Dec 5, 2018
Closed
BridgeAR added a commit that referenced this pull request Dec 5, 2018
util,console: handle symbols as defined in the spec
e13571c 
The `console` functions rely on the `util.format()` behavior. It
did not follow the whatwg spec when it comes to symbols in combination
with the %d, %i and %f format specifiers. Using a symbol argument in
combination with one of these specifiers resulted in an error instead
of returning `'NaN'`. This is now fixed by this patch.

PR-URL: #23708
Refs: https://console.spec.whatwg.org/#formatter
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
BridgeAR added a commit that referenced this pull request Dec 6, 2018
2018-12-06, Version 11.4.0 (Current)
758cb07 
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
BridgeAR added a commit that referenced this pull request Dec 7, 2018
2018-12-07, Version 11.4.0 (Current)
4f1297f 
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
BridgeAR added a commit that referenced this pull request Dec 7, 2018
2018-12-07, Version 11.4.0 (Current)
bcef949 
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
util,console: handle symbols as defined in the spec
aeae459 
The `console` functions rely on the `util.format()` behavior. It
did not follow the whatwg spec when it comes to symbols in combination
with the %d, %i and %f format specifiers. Using a symbol argument in
combination with one of these specifiers resulted in an error instead
of returning `'NaN'`. This is now fixed by this patch.

PR-URL: nodejs#23708
Refs: https://console.spec.whatwg.org/#formatter
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
2018-12-07, Version 11.4.0 (Current)
5912f6d 
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    nodejs#23708
  * The inspection `depth` default is now back at 2.
    nodejs#24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    nodejs#23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    nodejs#24739
* readline:
  * The `readline` module now supports async iterators.
    nodejs#23916
* repl:
  * The multiline history feature is removed.
    nodejs#24804
* tls:
  * Added min/max protocol version options.
    nodejs#24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. nodejs#24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    nodejs#23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    nodejs#24677
  * The install-tools scripts or now included in the dist.
    nodejs#24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    nodejs#24655

PR-URL: nodejs#24854
BridgeAR deleted the more-spec-compliant-util-format branch January 20, 2020 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau left review comments
+3 more reviewers
vsemozhetbyt vsemozhetbyt left review comments
silverwind silverwind approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. semver-minor PRs that contain new features and should be released in the next minor version. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL