FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build,win: distribute the install-tools scripts in the zip by refack · Pull Request #24233 · nodejs/node · GitHub

/ node Public

build,win: distribute the install-tools scripts in the zip - #24233

Closed
refack wants to merge 2 commits into
nodejs:masterfrom
refack:distribute-windows-install-tools-script
ConversationCommits (2)ChecksFiles changed
Closed

build,win: distribute the install-tools scripts in the zip#24233
refack wants to merge 2 commits into
nodejs:masterfrom
refack:distribute-windows-install-tools-script

Conversation

refack commented Nov 7, 2018

Copy link
Copy Markdown
Contributor
  • pack install-tools.* into the zip
  • reroute MSI files sources
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

refack added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. build Issues and PRs related to build files or the CI. labels Nov 7, 2018

nodejs-github-bot commented Nov 7, 2018

Copy link
Copy Markdown
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1530/pipeline

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 7, 2018
refack added semver-minor PRs that contain new features and should be released in the next minor version. and removed tools Issues and PRs related to the tools directory. labels Nov 7, 2018
refack mentioned this pull request Nov 7, 2018
Open
joaocgreis suggested changes Nov 10, 2018
View reviewed changes

joaocgreis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@refack the changes make sense, thanks! If you could test your changes locally before pushing, that would probably save us review cycles.

Comment thread vcbuild.bat Outdated
Comment thread tools/msvs/msi/product.wxs Outdated

refack commented Nov 11, 2018

Copy link
Copy Markdown
Contributor Author

If you could test your changes locally before pushing, that would probably save us review cycles.

Sorry for the broken code, but I couldn't test this locally. IMHO we should cover this code in the test CI, since we have had some regressions, and maybe some more are hiding here ¯_(ツ)_/¯

Trott commented Nov 20, 2018

Copy link
Copy Markdown
Member

@refack Still working on this (or planning to in any event)? Making sure we shouldn't apply the stalled or blocked labels (or help wanted) or anything like that...

refack force-pushed the distribute-windows-install-tools-script branch from f786fad to e815709 Compare November 25, 2018 00:44

refack commented Nov 25, 2018

Copy link
Copy Markdown
Contributor Author

Build test release - https://ci-release.nodejs.org/job/iojs+release/3961/

refack added the wip Issues and PRs that are still a work in progress. label Nov 25, 2018
refack force-pushed the distribute-windows-install-tools-script branch from e815709 to 0c802c5 Compare November 25, 2018 22:57
refack removed the wip Issues and PRs that are still a work in progress. label Nov 25, 2018

refack commented Nov 25, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Tested manually and in https://ci-release.nodejs.org/job/iojs+release/3963/ ✔️
@joaocgreis PTAL

Trott commented Nov 30, 2018

Copy link
Copy Markdown
Member

/ping @joaocgreis LGTY?

joaocgreis approved these changes Dec 4, 2018
View reviewed changes

joaocgreis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great now, thanks!

Trott commented Dec 5, 2018

Copy link
Copy Markdown
Member

Since this touches vcbuild.bat, a generic CI seems in order:
https://ci.nodejs.org/job/node-test-pull-request/19235/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 5, 2018

Trott commented Dec 5, 2018

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19246/

Trott commented Dec 6, 2018

Copy link
Copy Markdown
Member

Landed in 2fab5d5

Trott closed this Dec 6, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 6, 2018
build,win: pack the install-tools scripts for dist
2fab5d5 
PR-URL: nodejs#24233
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
BridgeAR pushed a commit that referenced this pull request Dec 6, 2018
build,win: pack the install-tools scripts for dist
66602ad 
PR-URL: #24233
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
BridgeAR added a commit that referenced this pull request Dec 6, 2018
2018-12-06, Version 11.4.0 (Current)
758cb07 
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
BridgeAR mentioned this pull request Dec 6, 2018
Merged
4 tasks
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
build,win: pack the install-tools scripts for dist
706bc41 
PR-URL: #24233
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
build,win: pack the install-tools scripts for dist
b80690d 
PR-URL: #24233
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
BridgeAR added a commit that referenced this pull request Dec 7, 2018
2018-12-07, Version 11.4.0 (Current)
4f1297f 
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
BridgeAR added a commit that referenced this pull request Dec 7, 2018
2018-12-07, Version 11.4.0 (Current)
bcef949 
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack deleted the distribute-windows-install-tools-script branch December 21, 2018 01:12
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
build,win: pack the install-tools scripts for dist
87fdadd 
PR-URL: nodejs#24233
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
2018-12-07, Version 11.4.0 (Current)
5912f6d 
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    nodejs#23708
  * The inspection `depth` default is now back at 2.
    nodejs#24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    nodejs#23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    nodejs#24739
* readline:
  * The `readline` module now supports async iterators.
    nodejs#23916
* repl:
  * The multiline history feature is removed.
    nodejs#24804
* tls:
  * Added min/max protocol version options.
    nodejs#24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. nodejs#24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    nodejs#23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    nodejs#24677
  * The install-tools scripts or now included in the dist.
    nodejs#24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    nodejs#24655

PR-URL: nodejs#24854
refack restored the distribute-windows-install-tools-script branch January 22, 2019 21:42

BethGriggs commented Sep 3, 2019

Copy link
Copy Markdown
Member

Should this land on v10.x? Please open a backport PR if so

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
richardlau richardlau approved these changes
bzoz Awaiting requested review from bzoz
+1 more reviewer
joaocgreis joaocgreis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. semver-minor PRs that contain new features and should be released in the next minor version. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL