FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add optional callback to socket.end by Ajido · Pull Request #23937 · nodejs/node · GitHub

/ node Public

doc: add optional callback to socket.end - #23937

Closed
Ajido wants to merge 2 commits into
nodejs:masterfrom
Ajido:master
ConversationCommits (2)ChecksFiles changed
Closed

doc: add optional callback to socket.end#23937
Ajido wants to merge 2 commits into
nodejs:masterfrom
Ajido:master

Conversation

Ajido commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

Since the optional callback was missing in the socket.end, I added it.

Refs: #18708

Checklist

nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Oct 28, 2018

vsemozhetbyt commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

CI fails as this ref needs to be updated now. It should be:

[`socket.end()`]: #net_socket_end_data_encoding_callback

vsemozhetbyt commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1401/

Ajido commented Oct 28, 2018

Copy link
Copy Markdown
Contributor Author

@vsemozhetbyt thank you for your review comments.

vsemozhetbyt added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 28, 2018

vsemozhetbyt commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 29, 2018

vsemozhetbyt commented Oct 29, 2018

Copy link
Copy Markdown
Contributor

Landed in 9697c08
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Oct 29, 2018
doc: add optional callback to socket.end()
9697c08 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 1, 2018
doc: add optional callback to socket.end()
f01a806 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Nov 1, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
Ajido mentioned this pull request Nov 4, 2018
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
doc: add optional callback to socket.end()
64c683b 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
doc: add optional callback to socket.end()
e14226c 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
test: add test for socket.end callback
628f955 
PR-URL: nodejs#24087
Refs: nodejs#23937
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 28, 2018
test: add test for socket.end callback
d6fff0e 
PR-URL: #24087
Refs: #23937
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
doc: add optional callback to socket.end()
cc22a2a 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
test: add test for socket.end callback
f4bd08e 
PR-URL: nodejs#24087
Refs: nodejs#23937
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
test: add test for socket.end callback
4093572 
PR-URL: #24087
Refs: #23937
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
test: add test for socket.end callback
6799d3b 
PR-URL: #24087
Refs: #23937
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
trivikr trivikr approved these changes
+1 more reviewer
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL