CI: https://ci.nodejs.org/job/node-test-pull-request/18334/

LGTM but maybe it's redundant because it's probably already covered by stream.Writable#end() tests and/or other tests. It doesn't harm though.

@lpinca Thank you for your review. You're right. This test is the same as below
https://github.com/nodejs/node/blob/master/test/parallel/test-stream2-writable.js

However, I think this test will ensure that net.Socket#end() provides the same interface as stream.Writable#end().

@lpinca By the way I looked at #19241 and just realized the need to consume socket data.
I think to add the below sentence to the net's document, what do you think?

https://nodejs.org/api/http.html#http_class_http_clientrequest

calling the .resume () method. Until the data is consumed, the 'end' event will not fire.

@Ajido that's how stream.Readable works. I think it's already documented in the stream docs. If not, then it makes sense to document it.

@lpinca Gotcha. Certainly it was explained already in stream.Readable doc, and it was already linked from net.Socket.
https://nodejs.org/api/stream.html#stream_event_end

Anyone else's approval?

@jasnell Thanks! CI jobs has failed in step not related to this PR. Can you please run CI again?
https://ci.nodejs.org/job/node-test-commit-arm/19690/nodes=debian8-docker-armv7/console

13:20:55 [debian8-docker-armv7] $ /bin/sh -xe /tmp/jenkins86729623692048483.sh
13:20:55 + set -x
13:20:55 + mkdir out/junit
13:20:55 mkdir: cannot create directory ‘out/junit’: No such file or directory
13:20:56 POST BUILD TASK : FAILURE
13:20:56 END OF POST BUILD TASK : 0
13:20:56 Recording test results
13:20:56 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

CI: https://ci.nodejs.org/job/node-test-pull-request/18949/

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18969/

Landed in 628f955

@Trott Many thanks! 😄