doc: correct async_hooks resource names - #24001
Closed
Flarna wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
addaleax
approved these changes
Oct 31, 2018
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cjihrig
approved these changes
Oct 31, 2018
pull Bot
pushed a commit
to SimenB/node
that referenced
this pull request
Nov 2, 2018
Correct async hooks resource names to match the implementation: `FSREQWRAP` => `FSREQCALLBACK` `TCPSERVER` => `TCPSERVERWRAP` PR-URL: nodejs#24001 Refs: nodejs#21971 Refs: nodejs#17157 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Nov 15, 2018
Copy link
Copy Markdown
Contributor
|
Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
it's only partial applicable (TCPSERVER => TCPSERVERWRAP) but this is also applicable to v8.x. Will create a PR later for 10.x |
Sorry, something went wrong.
This was referenced Nov 27, 2018
BethGriggs
pushed a commit
that referenced
this pull request
Dec 3, 2018
Merged
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct async hools resource names to match the implementation:
FSREQWRAP => FSREQCALLBACK
TCPSERVER => TCPSERVERWRAP
Refs: #21971
Refs: #17157
Checklist