FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v10.x backport] doc: correct async_hooks resource names by Flarna · Pull Request #24683 · nodejs/node · GitHub

/ node Public

[v10.x backport] doc: correct async_hooks resource names - #24683

Closed
Flarna wants to merge 1 commit into
nodejs:v10.x-stagingfrom
Flarna:v10-async_hooks_doc
ConversationCommits (1)ChecksFiles changed
Closed

[v10.x backport] doc: correct async_hooks resource names#24683
Flarna wants to merge 1 commit into
nodejs:v10.x-stagingfrom
Flarna:v10-async_hooks_doc

Conversation

Flarna commented Nov 27, 2018

Copy link
Copy Markdown
Member

Correct async hooks resource names to match the implementation:
TCPSERVER => TCPSERVERWRAP

Refs: #17157
Refs: #24001

Checklist

nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. v10.x labels Nov 27, 2018
Flarna mentioned this pull request Nov 27, 2018
Closed
2 tasks

Trott commented Nov 30, 2018

Copy link
Copy Markdown
Member

Needs a rebase or something? Seems to have far too many commits.

Flarna commented Nov 30, 2018

Copy link
Copy Markdown
Member Author

No idea what exactly I did wrong but it should be corrected now.

doc: correct async_hooks resource names
4f44456 
Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`

Refs: #17157

Flarna commented Dec 12, 2018

Copy link
Copy Markdown
Member Author

Rebased (twice)

MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
doc: correct async_hooks resource names
57ccaf6 
Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`

Backport-PR-URL: #24683
PR-URL: #24001
Refs: #21971
Refs: #17157
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

landed in 57ccaf6

Flarna deleted the v10-async_hooks_doc branch December 21, 2018 17:25
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
doc: correct async_hooks resource names
4209e12 
Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`

Backport-PR-URL: #24683
PR-URL: #24001
Refs: #21971
Refs: #17157
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL