FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH by trivikr · Pull Request #24126 · nodejs/node · GitHub

/ node Public

test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH - #24126

Closed
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:test-http2-origin-len
ConversationCommits (1)ChecksFiles changed
Closed

test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH#24126
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:test-http2-origin-len

Conversation

trivikr commented Nov 6, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot commented Nov 6, 2018

Copy link
Copy Markdown
Collaborator

@trivikr build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1511/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
BridgeAR approved these changes Nov 6, 2018
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

BridgeAR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
mhdawson approved these changes Nov 6, 2018
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

BridgeAR commented Nov 6, 2018

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/18364/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 6, 2018
refack reviewed Nov 6, 2018
View reviewed changes
Comment thread test/parallel/test-http2-origin.js Outdated

Trott commented Nov 8, 2018

Copy link
Copy Markdown
Member

I'm removing the code-and-learn label from this one because the author has nearly 30 commits in Node.js master branch.

Trott removed the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 8, 2018

Trott commented Nov 8, 2018

Copy link
Copy Markdown
Member

Removing author ready label due to pending comment from @refack.

Trott removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 8, 2018

antsmartian commented Dec 9, 2018

Copy link
Copy Markdown
Contributor

@trivikr ping..

trivikr force-pushed the test-http2-origin-len branch from 5a597c2 to 1f23c5a Compare December 14, 2018 05:27
Trott added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Feb 17, 2019
Trott force-pushed the test-http2-origin-len branch from 82ddba4 to 3bf4d66 Compare February 17, 2019 00:44

Trott commented Feb 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Rebased, resolved conflicts, force-pushed. A re-review or two would be swell.

CI: https://ci.nodejs.org/job/node-test-pull-request/20824/ ✅

Trott commented Feb 17, 2019

Copy link
Copy Markdown
Member

I guess since this throws a new error and HTTP2 is stable, this is semver major. Please correct me if I'm wrong.

Trott added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 17, 2019

Trott commented Feb 17, 2019

Copy link
Copy Markdown
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1742/

Trott commented Feb 17, 2019

Copy link
Copy Markdown
Member

Benchmarks seem OK.

                                                                                   confidence improvement accuracy (*)   (**)  (***)
 http2/compat.js benchmarker='h2load' clients=2 streams=1 requests=100                             0.33 %       ±3.21% ±4.28% ±5.59%
 http2/compat.js benchmarker='h2load' clients=2 streams=1 requests=1000                            0.09 %       ±2.57% ±3.42% ±4.45%
 http2/compat.js benchmarker='h2load' clients=2 streams=1 requests=5000                           -2.36 %       ±2.78% ±3.71% ±4.86%
 http2/compat.js benchmarker='h2load' clients=2 streams=10 requests=100                            0.03 %       ±2.65% ±3.53% ±4.60%
 http2/compat.js benchmarker='h2load' clients=2 streams=10 requests=1000                          -1.47 %       ±3.85% ±5.13% ±6.68%
 http2/compat.js benchmarker='h2load' clients=2 streams=10 requests=5000                          -0.44 %       ±2.88% ±3.83% ±4.98%
 http2/compat.js benchmarker='h2load' clients=2 streams=100 requests=100                           0.31 %       ±3.95% ±5.26% ±6.86%
 http2/compat.js benchmarker='h2load' clients=2 streams=100 requests=1000                         -1.64 %       ±2.64% ±3.52% ±4.58%
 http2/compat.js benchmarker='h2load' clients=2 streams=100 requests=5000                          0.60 %       ±2.06% ±2.75% ±3.57%
 http2/compat.js benchmarker='h2load' clients=2 streams=20 requests=100                            1.59 %       ±2.29% ±3.06% ±3.98%
 http2/compat.js benchmarker='h2load' clients=2 streams=20 requests=1000                          -0.67 %       ±2.97% ±3.97% ±5.20%
 http2/compat.js benchmarker='h2load' clients=2 streams=20 requests=5000                           0.95 %       ±2.65% ±3.54% ±4.61%
 http2/compat.js benchmarker='h2load' clients=2 streams=200 requests=100                          -2.51 %       ±3.29% ±4.41% ±5.80%
 http2/compat.js benchmarker='h2load' clients=2 streams=200 requests=1000                         -1.48 %       ±3.43% ±4.58% ±5.99%
 http2/compat.js benchmarker='h2load' clients=2 streams=200 requests=5000                          1.30 %       ±2.48% ±3.30% ±4.30%
 http2/compat.js benchmarker='h2load' clients=2 streams=40 requests=100                           -2.32 %       ±5.44% ±7.29% ±9.58%
 http2/compat.js benchmarker='h2load' clients=2 streams=40 requests=1000                          -1.39 %       ±3.24% ±4.31% ±5.61%
 http2/compat.js benchmarker='h2load' clients=2 streams=40 requests=5000                          -1.00 %       ±2.92% ±3.89% ±5.07%
 http2/headers.js nheaders=0 n=1000                                                               -0.28 %       ±0.90% ±1.20% ±1.57%
 http2/headers.js nheaders=10 n=1000                                                               1.22 %       ±1.55% ±2.06% ±2.70%
 http2/headers.js nheaders=100 n=1000                                                             -0.10 %       ±0.98% ±1.30% ±1.70%
 http2/headers.js nheaders=1000 n=1000                                                            -0.36 %       ±0.54% ±0.72% ±0.94%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=1 requests=100                   -1.25 %       ±2.21% ±2.95% ±3.84%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=1 requests=1000                  -0.88 %       ±1.31% ±1.75% ±2.28%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=1 requests=5000                   0.22 %       ±0.99% ±1.32% ±1.72%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=10 requests=100                   0.21 %       ±1.95% ±2.60% ±3.38%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=10 requests=1000                 -1.76 %       ±3.28% ±4.36% ±5.68%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=10 requests=5000                 -0.43 %       ±1.85% ±2.47% ±3.22%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=100 requests=100                 -0.20 %       ±3.93% ±5.24% ±6.83%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=100 requests=1000          *      1.84 %       ±1.41% ±1.88% ±2.45%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=100 requests=5000                 0.12 %       ±0.80% ±1.07% ±1.39%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=20 requests=100                  -0.77 %       ±1.66% ±2.21% ±2.87%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=20 requests=1000                 -0.06 %       ±1.73% ±2.30% ±3.00%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=20 requests=5000                  0.24 %       ±0.93% ±1.24% ±1.62%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=200 requests=100                  2.15 %       ±3.00% ±4.00% ±5.22%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=200 requests=1000                -0.95 %       ±1.89% ±2.52% ±3.29%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=200 requests=5000                -0.05 %       ±0.94% ±1.25% ±1.63%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=40 requests=100                  -1.76 %       ±3.40% ±4.53% ±5.91%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=40 requests=1000                  0.80 %       ±1.96% ±2.62% ±3.42%
 http2/respond-with-fd.js benchmarker='h2load' clients=2 streams=40 requests=5000          **     -1.23 %       ±0.88% ±1.17% ±1.52%
 http2/simple.js benchmarker='h2load' clients=2 streams=1 requests=100                            -0.57 %       ±2.46% ±3.28% ±4.28%
 http2/simple.js benchmarker='h2load' clients=2 streams=1 requests=1000                    **      2.12 %       ±1.52% ±2.03% ±2.65%
 http2/simple.js benchmarker='h2load' clients=2 streams=1 requests=5000                           -0.47 %       ±1.11% ±1.48% ±1.93%
 http2/simple.js benchmarker='h2load' clients=2 streams=10 requests=100                           -0.63 %       ±1.61% ±2.14% ±2.79%
 http2/simple.js benchmarker='h2load' clients=2 streams=10 requests=1000                          -0.74 %       ±1.47% ±1.95% ±2.54%
 http2/simple.js benchmarker='h2load' clients=2 streams=10 requests=5000                          -0.45 %       ±1.50% ±2.01% ±2.62%
 http2/simple.js benchmarker='h2load' clients=2 streams=100 requests=100                           1.88 %       ±2.07% ±2.75% ±3.58%
 http2/simple.js benchmarker='h2load' clients=2 streams=100 requests=1000                         -0.78 %       ±1.65% ±2.20% ±2.86%
 http2/simple.js benchmarker='h2load' clients=2 streams=100 requests=5000                          0.02 %       ±1.80% ±2.40% ±3.12%
 http2/simple.js benchmarker='h2load' clients=2 streams=20 requests=100                           -0.15 %       ±1.60% ±2.13% ±2.78%
 http2/simple.js benchmarker='h2load' clients=2 streams=20 requests=1000                           0.84 %       ±1.85% ±2.46% ±3.20%
 http2/simple.js benchmarker='h2load' clients=2 streams=20 requests=5000                          -0.47 %       ±2.12% ±2.83% ±3.68%
 http2/simple.js benchmarker='h2load' clients=2 streams=200 requests=100                           1.90 %       ±2.19% ±2.91% ±3.80%
 http2/simple.js benchmarker='h2load' clients=2 streams=200 requests=1000                          1.17 %       ±2.19% ±2.92% ±3.80%
 http2/simple.js benchmarker='h2load' clients=2 streams=200 requests=5000                         -1.52 %       ±1.78% ±2.37% ±3.09%
 http2/simple.js benchmarker='h2load' clients=2 streams=40 requests=100                            0.38 %       ±1.91% ±2.55% ±3.34%
 http2/simple.js benchmarker='h2load' clients=2 streams=40 requests=1000                           0.07 %       ±2.23% ±2.97% ±3.86%
 http2/simple.js benchmarker='h2load' clients=2 streams=40 requests=5000                           0.00 %       ±1.98% ±2.63% ±3.42%
 http2/write.js benchmarker='h2load' size=100000 length=1048576 streams=100                       -0.88 %       ±3.07% ±4.09% ±5.32%
 http2/write.js benchmarker='h2load' size=100000 length=1048576 streams=1000                       0.23 %       ±3.32% ±4.42% ±5.76%
 http2/write.js benchmarker='h2load' size=100000 length=1048576 streams=200                       -0.07 %       ±2.63% ±3.50% ±4.57%
 http2/write.js benchmarker='h2load' size=100000 length=131072 streams=100                        -0.88 %       ±3.22% ±4.30% ±5.63%
 http2/write.js benchmarker='h2load' size=100000 length=131072 streams=1000                        2.60 %       ±3.67% ±4.90% ±6.43%
 http2/write.js benchmarker='h2load' size=100000 length=131072 streams=200                         1.30 %       ±4.93% ±6.57% ±8.57%
 http2/write.js benchmarker='h2load' size=100000 length=262144 streams=100                        -0.34 %       ±3.03% ±4.04% ±5.26%
 http2/write.js benchmarker='h2load' size=100000 length=262144 streams=1000                       -0.90 %       ±4.44% ±5.92% ±7.70%
 http2/write.js benchmarker='h2load' size=100000 length=262144 streams=200                         1.17 %       ±3.15% ±4.20% ±5.47%
 http2/write.js benchmarker='h2load' size=100000 length=65536 streams=100                          1.78 %       ±4.32% ±5.77% ±7.56%
 http2/write.js benchmarker='h2load' size=100000 length=65536 streams=1000                         1.83 %       ±4.52% ±6.04% ±7.90%
 http2/write.js benchmarker='h2load' size=100000 length=65536 streams=200                         -0.20 %       ±5.49% ±7.32% ±9.55%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case there are 70 comparisons, you can thus
expect the following amount of false-positive results:
  3.50 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.70 false positives, when considering a   1% risk acceptance (**, ***),
  0.07 false positives, when considering a 0.1% risk acceptance (***)

Trott added the http2 Issues or PRs related to the http2 subsystem. label Feb 17, 2019

Trott commented Oct 23, 2019

Copy link
Copy Markdown
Member

What needs to happen for this to land? Seems like it would be:

  • rebase to eliminate conflicts
  • re-run CI and CITGM

Other than that, is there anything?

@trivikr Any chance you can get the conflicts resolved and kick off a CI?

trivikr commented Oct 24, 2019

Copy link
Copy Markdown
Member Author

Closing this PR, as it was implemented in the following ones:

trivikr closed this Oct 24, 2019
trivikr deleted the test-http2-origin-len branch October 24, 2019 04:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bengl bengl approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
+3 more reviewers
refack refack left review comments
rubys rubys approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

http2 Issues or PRs related to the http2 subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL