FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH by fshaikh · Pull Request #25296 · nodejs/node · GitHub

/ node Public

test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH - #25296

Closed
fshaikh wants to merge 2 commits into
nodejs:masterfrom
fshaikh:test-http2-origin-len
ConversationCommits (2)ChecksFiles changed
Closed

test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH#25296
fshaikh wants to merge 2 commits into
nodejs:masterfrom
fshaikh:test-http2-origin-len

Conversation

fshaikh commented Dec 31, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x ] tests and/or benchmarks are included
  • [x ] commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 31, 2018
antsmartian approved these changes Jan 1, 2019
View reviewed changes

antsmartian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM..

(I guess we had the same test case written over this PR: #24014 and it wasn't merged but got closed)

antsmartian commented Jan 1, 2019

Copy link
Copy Markdown
Contributor

Hello @fshaikh and thanks for your first pull request. I see linter issue, could you please fix the below:

/home/travis/build/nodejs/node/test/parallel/test-http2-origin.js
  73:59  error  Missing semicolon  semi

antsmartian added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 2, 2019

antsmartian commented Jan 2, 2019

Copy link
Copy Markdown
Contributor

CI Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2123/

addaleax commented Jan 2, 2019

Copy link
Copy Markdown
Member

Full CI: https://ci.nodejs.org/job/node-test-pull-request/19913/

danbev commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

Landed in 076d8b9. 🎉

danbev closed this Jan 7, 2019
danbev pushed a commit that referenced this pull request Jan 7, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
076d8b9 
PR-URL: #25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 9, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
239d5ec 
PR-URL: #25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
f817f57 
PR-URL: nodejs#25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
890c7b6 
PR-URL: nodejs#25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
2936958 
PR-URL: #25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
f8d6e3f 
PR-URL: #25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
374a07d 
PR-URL: #25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
trivikr mentioned this pull request Oct 24, 2019
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
antsmartian antsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL