FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: add maxHeaderSize property by cjihrig · Pull Request #24860 · nodejs/node · GitHub

/ node Public

http: add maxHeaderSize property - #24860

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:http-max-headers
Dec 20, 2018
ConversationCommits (1)ChecksFiles changed
Merged

http: add maxHeaderSize property#24860
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:http-max-headers

Conversation

cjihrig commented Dec 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Requested by @mcollina in #24811 , but I didn't want to stall that out. Ignore the commits to deps and cli, which are just #24811.

This PR exposes the value of --max-http-header-size as a property of the http module.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Dec 6, 2018

Copy link
Copy Markdown
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1847/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 6, 2018
cjihrig mentioned this pull request Dec 6, 2018
Merged
4 tasks
mcollina approved these changes Dec 7, 2018
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson approved these changes Dec 12, 2018
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mcollina commented Dec 12, 2018

Copy link
Copy Markdown
Member

@nodejs/lts would you be ok in backporting this to 6/8/10?

sam-github reviewed Dec 12, 2018
View reviewed changes
Comment thread lib/http.js Outdated

sam-github Dec 12, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should this be configurable: false, writeable: false?

cjihrig Dec 20, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

writable is not supported on accessor descriptors.

Comment thread doc/api/cli.md Outdated
Comment thread doc/api/http.md Outdated
cjihrig added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 20, 2018
http: add maxHeaderSize property
9ac108d 
This commit exposes the value of --max-http-header-size
as a property of the http module.

PR-URL: nodejs#24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

cjihrig commented Dec 20, 2018

Copy link
Copy Markdown
Contributor Author

Green CI: https://ci.nodejs.org/job/node-test-pull-request/19695/

cjihrig merged commit 9ac108d into nodejs:master Dec 20, 2018
cjihrig deleted the http-max-headers branch December 20, 2018 18:17
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
http: add maxHeaderSize property
5e1ec70 
This commit exposes the value of --max-http-header-size
as a property of the http module.

PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins commented Dec 25, 2018

Copy link
Copy Markdown
Contributor

Should this be included in the various releases being prepared for 6.x -> 11.x right now?

mcollina commented Dec 25, 2018

Copy link
Copy Markdown
Member

I think so, yes.

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Dec 25, 2018
http: add maxHeaderSize property
e59cc49 
This commit exposes the value of --max-http-header-size
as a property of the http module.

PR-URL: nodejs#24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
http: add maxHeaderSize property
17f4208 
This commit exposes the value of --max-http-header-size
as a property of the http module.

PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
http: add maxHeaderSize property
c5142b3 
This commit exposes the value of --max-http-header-size
as a property of the http module.

Backport-PR-URL: #25218
PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
http: add maxHeaderSize property
b6d3afb 
This commit exposes the value of --max-http-header-size
as a property of the http module.

PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
http: add maxHeaderSize property
446f8b5 
This commit exposes the value of --max-http-header-size
as a property of the http module.

Backport-PR-URL: #25218
PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
http: add maxHeaderSize property
b69e096 
This commit exposes the value of --max-http-header-size
as a property of the http module.

Backport-PR-URL: #25218
PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
http: add maxHeaderSize property
c0c4de7 
This commit exposes the value of --max-http-header-size
as a property of the http module.

Backport-PR-URL: #25218
PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 25, 2018
Merged
Merged
Merged
MylesBorins added a commit that referenced this pull request Dec 25, 2018
2018-12-26, Version 6.16.0 'Boron' (LTS)
a3aa4b4 
The 6.15.0 security release introduced some unexpected breakages on
the 6.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25178
MylesBorins added a commit that referenced this pull request Dec 25, 2018
2018-12-26, Version 8.15.0 'Carbon' (LTS)
6d1c367 
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25177
MylesBorins added a commit that referenced this pull request Dec 25, 2018
2018-12-26, Version 11.6.0 (Current)
f59e73b 
Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* crypto:
  - always accept certificates as public keys (Tobias Nießen)
    #24234
  - add key object API (Tobias Nießen) [#24234](#24234)
  - update root certificates (Sam Roberts)
    #25113
* deps:
  - upgrade to libuv 1.24.1 (cjihrig)
    #25078
  - upgrade npm to 6.5.0 (Audrey Eschright)
    #24734
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25175
MylesBorins mentioned this pull request Dec 25, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
http: add maxHeaderSize property
ae50f48 
This commit exposes the value of --max-http-header-size
as a property of the http module.

PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 26, 2018
2018-12-26, Version 11.6.0 (Current)
fb9130f 
Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* crypto:
  - always accept certificates as public keys (Tobias Nießen)
    #24234
  - add key object API (Tobias Nießen) [#24234](#24234)
  - update root certificates (Sam Roberts)
    #25113
* deps:
  - upgrade to libuv 1.24.1 (cjihrig)
    #25078
  - upgrade npm to 6.5.0 (Audrey Eschright)
    #24734
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25175
MylesBorins added a commit that referenced this pull request Dec 26, 2018
2018-12-26, Version 11.6.0 (Current)
968e901 
Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* crypto:
  - always accept certificates as public keys (Tobias Nießen)
    #24234
  - add key object API (Tobias Nießen) [#24234](#24234)
  - update root certificates (Sam Roberts)
    #25113
* deps:
  - upgrade to libuv 1.24.1 (cjihrig)
    #25078
  - upgrade npm to 6.5.0 (Audrey Eschright)
    #24734
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25175
MylesBorins added a commit that referenced this pull request Dec 26, 2018
2018-12-26, Version 6.16.0 'Boron' (LTS)
7b9c9b3 
The 6.15.0 security release introduced some unexpected breakages on
the 6.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25178
MylesBorins added a commit that referenced this pull request Dec 26, 2018
2018-12-26, Version 8.15.0 'Carbon' (LTS)
9542324 
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25177
MylesBorins added a commit that referenced this pull request Dec 26, 2018
2018-12-26, Version 10.15.0 'Dubnium' (LTS)
78f2e14 
The 10.14.0 security release introduced some unexpected breakages on
the 10.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25176
MylesBorins added a commit that referenced this pull request Dec 26, 2018
2018-12-26, Version 11.6.0 (Current)
e01999d 
Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* crypto:
  - always accept certificates as public keys (Tobias Nießen)
    #24234
  - add key object API (Tobias Nießen) [#24234](#24234)
  - update root certificates (Sam Roberts)
    #25113
* deps:
  - upgrade to libuv 1.24.1 (cjihrig)
    #25078
  - upgrade npm to 6.5.0 (Audrey Eschright)
    #24734
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25175
This was referenced Dec 26, 2018
Closed
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
http: add maxHeaderSize property
d484553 
This commit exposes the value of --max-http-header-size
as a property of the http module.

PR-URL: nodejs#24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
2018-12-26, Version 6.16.0 'Boron' (LTS)
3de976b 
The 6.15.0 security release introduced some unexpected breakages on
the 6.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    nodejs#24811
* http:
  - add maxHeaderSize property (cjihrig)
    nodejs#24860

PR-URL: nodejs#25178
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
2018-12-26, Version 8.15.0 'Carbon' (LTS)
2b68938 
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    nodejs#24811
* http:
  - add maxHeaderSize property (cjihrig)
    nodejs#24860

PR-URL: nodejs#25177
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
2018-12-26, Version 10.15.0 'Dubnium' (LTS)
19c72e3 
The 10.14.0 security release introduced some unexpected breakages on
the 10.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    nodejs#24811
* http:
  - add maxHeaderSize property (cjihrig)
    nodejs#24860

PR-URL: nodejs#25176
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
2018-12-26, Version 11.6.0 (Current)
c842f7b 
Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    nodejs#24811
* crypto:
  - always accept certificates as public keys (Tobias Nießen)
    nodejs#24234
  - add key object API (Tobias Nießen) [nodejs#24234](nodejs#24234)
  - update root certificates (Sam Roberts)
    nodejs#25113
* deps:
  - upgrade to libuv 1.24.1 (cjihrig)
    nodejs#25078
  - upgrade npm to 6.5.0 (Audrey Eschright)
    nodejs#24734
* http:
  - add maxHeaderSize property (cjihrig)
    nodejs#24860

PR-URL: nodejs#25175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
codebytere codebytere approved these changes
richardlau richardlau approved these changes
+2 more reviewers
sam-github sam-github left review comments
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL