FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

v8.15.0 proposal by MylesBorins · Pull Request #25177 · nodejs/node · GitHub

/ node Public

v8.15.0 proposal - #25177

Merged
MylesBorins merged 7 commits into
v8.xfrom
v8.15.0-proposal
Dec 26, 2018
ConversationCommits (7)ChecksFiles changed
Merged

v8.15.0 proposal#25177
MylesBorins merged 7 commits into
v8.xfrom
v8.15.0-proposal

Conversation

MylesBorins commented Dec 21, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

2018-12-26, Version 8.15.0 'Carbon' (LTS), @MylesBorins

The 8.14.0 security release introduced some unexpected breakages on the 8.x release line.
This is a special release to fix a regression in the HTTP binary upgrade response body and add
a missing CLI flag to adjust the max header size of the http parser.

Notable changes

  • cli:
    • add --max-http-header-size flag (cjihrig) #24811
  • http:
    • add maxHeaderSize property (cjihrig) #24860

Commits

  • [693e362175] - (SEMVER-MINOR) cli: add --max-http-header-size flag (cjihrig) #24811
  • [4fb5a1be2f] - (SEMVER-MINOR) deps: cherry-pick http_parser_set_max_header_size (cjihrig) #24811
  • [446f8b54e5] - (SEMVER-MINOR) http: add maxHeaderSize property (cjihrig) #24860
  • [215ecfe4de] - http: fix regression of binary upgrade response body (Matteo Collina) #25037
  • [e1fbc26c6a] - test: move test-benchmark-path to sequential (Rich Trott) #21393
  • [aef71c05a2] - test: mark test-http2-settings-flood as flaky on Windows (Rich Trott) #25048

nodejs-github-bot commented Dec 21, 2018

Copy link
Copy Markdown
Collaborator

@MylesBorins build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2036/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Dec 21, 2018
MylesBorins added a commit that referenced this pull request Dec 21, 2018
2018-12-26, Version 8.15.0 'Carbon' (LTS)
d4331bf 
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811

PR-URL: #25177
MylesBorins mentioned this pull request Dec 21, 2018
Closed

MylesBorins commented Dec 21, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19733/

Trott and others added 5 commits December 21, 2018 23:55
test: mark test-http2-settings-flood as flaky on Windows
aef71c0 
Refs: #25043
PR-URL: #25048
Reviewed-By: Myles Borins <myles.borins@gmail.com>
test: move test-benchmark-path to sequential
e1fbc26 
Fixes: #18254

PR-URL: #21393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
http: fix regression of binary upgrade response body
215ecfe 
See: #24958

PR-URL: #25037
Reviewed-By: Myles Borins <myles.borins@gmail.com>
deps: cherry-pick http_parser_set_max_header_size
4fb5a1b 
This commit adds http_parser_set_max_header_size() to the
http-parser for overriding the compile time maximum HTTP
header size.

Backport-PR-URL: #25171
PR-URL: #24811
Fixes: #24692
Refs: nodejs/http-parser#453
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
cli: add --max-http-header-size flag
693e362 
Allow the maximum size of HTTP headers to be overridden from
the command line.

Backport-PR-URL: #25171
co-authored-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #24811
Fixes: #24692
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins added a commit that referenced this pull request Dec 22, 2018
2018-12-26, Version 8.15.0 'Carbon' (LTS)
f0a96fc 
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811

PR-URL: #25177

MylesBorins commented Dec 22, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19746/ ✅
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1698/ (LGTM)
rc.1: https://nodejs.org/download/rc/v8.15.0-rc.1/

mcollina approved these changes Dec 22, 2018
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

http: add maxHeaderSize property
446f8b5 
This commit exposes the value of --max-http-header-size
as a property of the http module.

Backport-PR-URL: #25218
PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins commented Dec 25, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19802/ ✅(single failure is known flake on AIX)
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1702/ ✅(manually tested failures and updated skip / flaky references in citgm lookup)
rc.2: https://nodejs.org/download/rc/v8.15.0-rc.2/

2018-12-26, Version 8.15.0 'Carbon' (LTS)
6d1c367 
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25177
MylesBorins merged commit 6d1c367 into v8.x Dec 26, 2018
MylesBorins added a commit that referenced this pull request Dec 26, 2018
Working on v8.15.1
852d25b 
PR-URL: #25177
MylesBorins added a commit that referenced this pull request Dec 26, 2018
2018-12-26, Version 8.15.0 'Carbon' (LTS)
9542324 
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25177
MylesBorins mentioned this pull request Dec 26, 2018
Merged
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
2018-12-26, Version 8.15.0 'Carbon' (LTS)
2b68938 
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    nodejs#24811
* http:
  - add maxHeaderSize property (cjihrig)
    nodejs#24860

PR-URL: nodejs#25177
targos deleted the v8.15.0-proposal branch June 4, 2019 14:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL