FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove `inherits()` usage by ZYSzys · Pull Request #25245 · nodejs/node · GitHub

/ node Public

test: remove inherits() usage - #25245

Closed
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:test-remove-util-inherits
ConversationCommits (1)ChecksFiles changed
Closed

test: remove inherits() usage#25245
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:test-remove-util-inherits

Conversation

ZYSzys commented Dec 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

This switches all util.inherits() calls to use Object.setPrototypeOf() instead in the test dir.

Only the test-util-inherits is preserve since util.inherits() isn't removed entirely.

Refs: #24755 #24395

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 28, 2018

addaleax commented Dec 30, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19871/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 30, 2018

addaleax commented Dec 31, 2018 •
edited by Trott
Loading

Copy link
Copy Markdown
Member

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19881/ ✅

Trott commented Dec 31, 2018

Copy link
Copy Markdown
Member

Landed in 2f981cd

Trott closed this Dec 31, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 31, 2018
test: remove util.inherits() usage
2f981cd 
PR-URL: nodejs#25245
Refs: nodejs#24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
ZYSzys deleted the test-remove-util-inherits branch December 31, 2018 04:08
targos pushed a commit that referenced this pull request Jan 1, 2019
test: remove util.inherits() usage
4ca4b54 
PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
test: remove util.inherits() usage
ada2f32 
PR-URL: nodejs#25245
Refs: nodejs#24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR mentioned this pull request Jan 16, 2019
Merged
MylesBorins mentioned this pull request Jan 24, 2019
Merged
ZYSzys mentioned this pull request Jul 21, 2019
Closed
3 tasks
BethGriggs pushed a commit that referenced this pull request Jul 26, 2019
test: remove util.inherits() usage
f332265 
Backport-PR-URL: #28795
PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs mentioned this pull request Jul 26, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL