FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v10.x backport] test: remove `util.inherits()` usage by ZYSzys · Pull Request #28795 · nodejs/node · GitHub

/ node Public

[v10.x backport] test: remove util.inherits() usage - #28795

Closed
ZYSzys wants to merge 1 commit into
nodejs:v10.x-stagingfrom
zys-contrib:backport-25245-to-v10.x
ConversationCommits (1)ChecksFiles changed
Closed

[v10.x backport] test: remove util.inherits() usage#28795
ZYSzys wants to merge 1 commit into
nodejs:v10.x-stagingfrom
zys-contrib:backport-25245-to-v10.x

Conversation

ZYSzys commented Jul 21, 2019

Copy link
Copy Markdown
Member

PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Anna Henningsen anna@addaleax.net

Backport of #25245

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

test: remove util.inherits() usage
488c981 
PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot added test Issues and PRs related to the tests. v10.x labels Jul 21, 2019

lpinca commented Jul 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

I don't think this should be backported. #24755 was semver-major. The _super property is no longer available.

lpinca commented Jul 21, 2019

Copy link
Copy Markdown
Member

Oh nvm it seems the change only affects tests.

nodejs-github-bot commented Jul 23, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24631/

nodejs-github-bot commented Jul 23, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24640/

nodejs-github-bot commented Jul 24, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24651/

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Jul 25, 2019 •
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24692/ ✔️

BethGriggs pushed a commit that referenced this pull request Jul 26, 2019
test: remove util.inherits() usage
f332265 
Backport-PR-URL: #28795
PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

BethGriggs commented Jul 26, 2019

Copy link
Copy Markdown
Member

Landed on v10.x-staging

BethGriggs closed this Jul 26, 2019
ZYSzys deleted the backport-25245-to-v10.x branch July 26, 2019 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BethGriggs BethGriggs approved these changes

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL