build: set `-blibpath:` for AIX by richardlau · Pull Request #25447 · nodejs/node · GitHub

#17604 refactored the gyp files
so that -blibpath: on AIX was only set if node_shared=="true".
Restore the setting for non-shared builds.

Fixes: #25444

cc @nodejs/build-files @nodejs/platform-aix

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: nodejs#25444

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2234/pipeline

Locally built:

bash-4.4$ dump -X64 -H out/Release/node

out/Release/node:

                        ***Loader Section***
                      Loader Header Information
VERSION#         #SYMtableENT     #RELOCent        LENidSTR
0x00000001       0x0000c49b       0x00027893       0x000000a4

#IMPfilID        OFFidSTR         LENstrTBL        OFFstrTBL
0x00000006       0x0039f7f0       0x0033a49e       0x0039f894


                        ***Import File Strings***
INDEX  PATH                          BASE                MEMBER
0      /usr/lib:/lib:/opt/freeware/lib/pthread/ppc64
1                                    libperfstat.a       shr_64.o
2                                    libstdc++.a         libstdc++.so.6
3                                    libgcc_s.a          shr.o
4                                    libpthreads.a       shr_xpg5_64.o
5                                    libc.a              shr_64.o
bash-4.4$

CI: https://ci.nodejs.org/job/node-test-pull-request/20062/

I'd like this not to land until the discussion on whether its the right thing to do completes.

LGTM. Ok I see this actually fixes a regression and it was that way before assuming CI passes of course.

@richardlau did you check that the fix that caused the regression was backported to 6.x and 8.x ?

I see it was backported to 6.x and 8.x so never mind.

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20070/

Resuming again: https://ci.nodejs.org/job/node-test-pull-request/20071/

Resume: https://ci.nodejs.org/job/node-test-pull-request/20093/ ✔️

Landed in bd8d682

#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: #25444 PR-URL: #25447 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Backport to v8.x-staging: #25521 (as requested).

nodejs#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: nodejs#25444 PR-URL: nodejs#25447 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: #25444 PR-URL: #25447 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

nodejs#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: nodejs#25444 Backport-PR-URL: nodejs#25521 PR-URL: nodejs#25447 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

nodejs#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: nodejs#25444 Backport-PR-URL: nodejs#26478 PR-URL: nodejs#25447 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: #25444 Backport-PR-URL: #26478 PR-URL: #25447 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: #25444 Backport-PR-URL: #25521 PR-URL: #25447 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

build: set -blibpath: for AIX

36839de

nodejs#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: nodejs#25444

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 11, 2019

richardlau mentioned this pull request Jan 11, 2019

LIBPATH issue in AIX node binary #25444

Closed

richardlau added the aix Issues and PRs related to the AIX platform. label Jan 11, 2019

gireeshpunathil approved these changes Jan 11, 2019

View reviewed changes

richardlau added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. lts-watch-v10.x labels Jan 11, 2019

mhdawson suggested changes Jan 11, 2019

View reviewed changes

mhdawson approved these changes Jan 11, 2019

View reviewed changes

refack reviewed Jan 12, 2019

View reviewed changes

Comment thread common.gypi

addaleax closed this Jan 14, 2019

This was referenced Jan 15, 2019

[Tracking] Additional semver minor to 8.x during maintenance nodejs/Release#405

Closed

[v8.x backport] build: set -blibpath: for AIX #25521

Closed

richardlau added backport-requested-v8.x and removed lts-watch-v8.x labels Jan 15, 2019

richardlau added the regression Issues related to regressions. label Jan 15, 2019

This was referenced Jan 16, 2019

CI failures: 20190110 - 20190116 nodejs/reliability#20

Closed

Windows CI failures: parallel/test-trace-events-fs-sync #25512

Closed

BridgeAR mentioned this pull request Jan 16, 2019

v11.7.0 proposal #25537

Merged

MylesBorins mentioned this pull request Jan 24, 2019

v11.8.0 proposal #25687

Merged

richardlau mentioned this pull request Feb 6, 2019

Final 6.x release before EOL? [Discussion] nodejs/Release#414

Closed

richardlau mentioned this pull request Mar 6, 2019

[v6.x backport] build: set -blibpath: for AIX #26478

Closed

2 tasks

BethGriggs mentioned this pull request Mar 15, 2019

v6.17.1 proposal #26684

Merged

MylesBorins mentioned this pull request Mar 26, 2019

v8.16.0 proposal #26933

Merged

beevelop mentioned this pull request Apr 3, 2019

2019-04-03 Version 6.17.1 'Boron' (LTS) @BethGriggs beevelop/docker-android-nodejs#299

Closed

BethGriggs added land-on-v10.x and removed lts-watch-v10.x labels Jul 9, 2019

build: set `-blibpath:` for AIX by richardlau · Pull Request #25447 · nodejs/node · GitHub

Uh oh!

Uh oh!

build: set -blibpath: for AIX - #25447

build: set -blibpath: for AIX#25447richardlau wants to merge 1 commit intonodejs:masternodejs/node:masterfrom richardlau:restore-aix-blibpathrichardlau/node-1:restore-aix-blibpathCopy head branch name to clipboard

Conversation

richardlau commented Jan 11, 2019

Checklist

Uh oh!

nodejs-github-bot commented Jan 11, 2019

Uh oh!

richardlau commented Jan 11, 2019

Uh oh!

richardlau commented Jan 11, 2019

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

mhdawson left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mhdawson commented Jan 11, 2019

Uh oh!

mhdawson commented Jan 11, 2019

Uh oh!

richardlau commented Jan 12, 2019

Uh oh!

richardlau commented Jan 12, 2019

Uh oh!

Uh oh!

richardlau commented Jan 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

addaleax commented Jan 14, 2019

Uh oh!

richardlau commented Jan 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

build: set -blibpath: for AIX#25447
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:restore-aix-blibpath

mhdawson left a comment •
edited
Loading

richardlau commented Jan 14, 2019 •
edited
Loading