FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v6.x backport] build: set `-blibpath:` for AIX by richardlau · Pull Request #26478 · nodejs/node · GitHub

/ node Public

[v6.x backport] build: set -blibpath: for AIX - #26478

Closed
richardlau wants to merge 1 commit into
nodejs:v6.x-stagingfrom
richardlau:restore-aix-blibpath-6
ConversationCommits (1)ChecksFiles changed
Closed

[v6.x backport] build: set -blibpath: for AIX#26478
richardlau wants to merge 1 commit into
nodejs:v6.x-stagingfrom
richardlau:restore-aix-blibpath-6

Conversation

richardlau commented Mar 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

#17604 refactored the gyp files
so that -blibpath: on AIX was only set if node_shared=="true".
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Mar 6, 2019

Copy link
Copy Markdown
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2788/pipeline

nodejs-github-bot added build Issues and PRs related to build files or the CI. v6.x labels Mar 6, 2019
richardlau force-pushed the restore-aix-blibpath-6 branch from 0e3e404 to d40535b Compare March 6, 2019 20:59

richardlau commented Mar 6, 2019

Copy link
Copy Markdown
Member Author

See nodejs/Release#414 (comment).

#25447 doesn't cherry-pick cleanly to v6.x-staging but the backport to v8.x-staging (#25521) does.

CI: https://ci.nodejs.org/job/node-test-pull-request/21282/

richardlau mentioned this pull request Mar 6, 2019
Closed
richardlau added aix Issues and PRs related to the AIX platform. regression Issues related to regressions. labels Mar 6, 2019

richardlau commented Mar 7, 2019

Copy link
Copy Markdown
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21306/

richardlau commented Mar 7, 2019

Copy link
Copy Markdown
Member Author

Windows failures look like infra: nodejs/build#1716

build: set -blibpath: for AIX
7b34f81 
nodejs#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: nodejs#25444

Backport-PR-URL: nodejs#26478
PR-URL: nodejs#25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
richardlau force-pushed the restore-aix-blibpath-6 branch from d40535b to 7b34f81 Compare March 12, 2019 17:52

richardlau commented Mar 12, 2019

Copy link
Copy Markdown
Member Author

Rebased onto current v6.x-staging.

New CI: https://ci.nodejs.org/job/node-test-pull-request/21470/

mhdawson approved these changes Mar 12, 2019
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

BethGriggs pushed a commit that referenced this pull request Mar 15, 2019
build: set -blibpath: for AIX
c9d21a0 
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

Backport-PR-URL: #26478
PR-URL: #25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BethGriggs commented Mar 15, 2019

Copy link
Copy Markdown
Member

Landed on v6.x-staging

BethGriggs closed this Mar 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BethGriggs BethGriggs approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

aix Issues and PRs related to the AIX platform. build Issues and PRs related to build files or the CI. regression Issues related to regressions.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL