FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: bump minimal supported GCC version to 5 by targos · Pull Request #25683 · nodejs/node · GitHub

/ node Public

meta: bump minimal supported GCC version to 5 - #25683

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:gcc-5
ConversationCommits (1)ChecksFiles changed
Closed

meta: bump minimal supported GCC version to 5#25683
targos wants to merge 1 commit into
nodejs:masterfrom
targos:gcc-5

Conversation

targos commented Jan 24, 2019

Copy link
Copy Markdown
Member

V8 is going to require full support for C++14.

/cc @hashseed @nodejs/v8 @nodejs/build

I don't actually know if there is a version 5.1.0. Happy to put another higher number.

meta: bump minimal supported GCC version to 5
e8a2d3e 
V8 is going to require full support for C++14.

nodejs-github-bot commented Jan 24, 2019

Copy link
Copy Markdown
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2371/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 24, 2019
targos added semver-major PRs that contain breaking changes and should be released in the next major version. build Issues and PRs related to build files or the CI. labels Jan 24, 2019

targos commented Jan 24, 2019

Copy link
Copy Markdown
Member Author

@nodejs/platform-smartos what should we do about the note in https://github.com/nodejs/node/blob/master/BUILDING.md#supported-platforms-1 ?

refack commented Jan 24, 2019

Copy link
Copy Markdown
Contributor

Refs: nodejs/build#1543

If we are planning a compiler bump, I'd rather we go with the latest stable version available (GCC 8.2 or LLVM/CLang 7)

ofrobots commented Jan 24, 2019

Copy link
Copy Markdown
Contributor

If we are planning a compiler bump, I'd rather we go with the latest stable version available (GCC 8.2 or LLVM/CLang 7)

+1 on this as long as @nodejs/build signs off that we can actually make that compiler version available on all the arch / os / distro combinations.

refack mentioned this pull request Jan 24, 2019
Closed
3 tasks

refack commented Jan 24, 2019

Copy link
Copy Markdown
Contributor

@nodejs/platform-smartos what should we do about the note in /BUILDING.md@master#supported-platforms-1 ?

Seems like note is outdated - #25684

targos commented Jan 24, 2019

Copy link
Copy Markdown
Member Author

+1 from me too if it's doable

mscdex commented Jan 24, 2019

Copy link
Copy Markdown
Contributor

If we are planning a compiler bump, I'd rather we go with the latest stable version available (GCC 8.2 or LLVM/CLang 7)

FWIW Ubuntu 16.04, which is still supported by Canonical into 2021 only has GCC 5.4.0 in its official repositories. Even Ubuntu 18.04 only ships with GCC 7.3.0.

ebraminio mentioned this pull request Jan 24, 2019
Closed

mhdawson commented Jan 24, 2019

Copy link
Copy Markdown
Member

I agree that we should factor in what comes by "default" in the distros, we also need to understand the impacts in terms of libc. I'm also thinking we might want to give ourselves more runway to get all of the compilers in place and plan the bump to be post Node.js 12.X

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 4, 2019
meta: update note about building on smartOS 16
000788e 
PR-URL: nodejs#25684
Refs: nodejs#25683
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 4, 2019
meta: update note about building on smartOS 16
74b9807 
PR-URL: #25684
Refs: #25683
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 5, 2019
meta: update note about building on smartOS 16
b25694d 
PR-URL: #25684
Refs: #25683
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR commented Mar 21, 2019

Copy link
Copy Markdown
Member

What's the status quo here? I guess we have to bump this for v12?

richardlau commented Mar 21, 2019

Copy link
Copy Markdown
Member

For 12 #26714 takes card of BUILDING.md and I raised #26719 for the configure changes (sorry @targos, didn't realise this one was open and had you pointed it out when you reviewed #26719 I'd have been happy to close it in favour of updates to this one).

The src/node_file.h change isn't covered elsewhere AFAICT.

targos commented Mar 21, 2019

Copy link
Copy Markdown
Member Author

I'm happy to close this, no problem @richardlau !

targos closed this Mar 21, 2019
targos deleted the gcc-5 branch October 17, 2020 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL