FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: update configure for Node.js 12 by richardlau · Pull Request #26719 · nodejs/node · GitHub

/ node Public

build: update configure for Node.js 12 - #26719

Merged
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:configure12
Mar 22, 2019
ConversationCommits (1)ChecksFiles changed
Merged

build: update configure for Node.js 12#26719
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:configure12

Conversation

richardlau commented Mar 17, 2019

Copy link
Copy Markdown
Member

Refs: #26714

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

richardlau added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 17, 2019

nodejs-github-bot commented Mar 17, 2019

Copy link
Copy Markdown
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2944/pipeline

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Mar 17, 2019

richardlau commented Mar 17, 2019

Copy link
Copy Markdown
Member Author

Note that this check is a warning and doesn't prevent you attempting to use older compilers.

richardlau commented Mar 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/21612/ (✔️)

mscdex commented Mar 17, 2019

Copy link
Copy Markdown
Contributor

If this is just a warning, perhaps the language in the commit message is a bit too strong?

richardlau commented Mar 17, 2019

Copy link
Copy Markdown
Member Author

If this is just a warning, perhaps the language in the commit message is a bit too strong?

¯\_(ツ)_/¯ It's the language we used in previous commits (79773f8, b4f59a7). I used build rather than doc as the subsystem as I felt it's more appropriate).

refack commented Mar 17, 2019

Copy link
Copy Markdown
Contributor

Note that this check is a warning and doesn't prevent you attempting to use older compilers.

IMHO that makes this not semver-major, just a "don't land on X"

targos commented Mar 17, 2019

Copy link
Copy Markdown
Member

I agree. #26714 being semver-major is enough

richardlau added dont-land-on-v6.x and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Mar 17, 2019
refack reviewed Mar 17, 2019
View reviewed changes
Comment thread configure.py Outdated
richardlau changed the title build: update configure to require g++ 6.3.0 build: update configure for Node.js 12 Mar 21, 2019

richardlau commented Mar 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Updated the commit message and clang level. PTAL.

New CI: https://ci.nodejs.org/job/node-test-pull-request/21714/ (✔️)

richardlau mentioned this pull request Mar 21, 2019
Closed
richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 21, 2019

refack commented Mar 22, 2019

Copy link
Copy Markdown
Contributor

I think it's good to capture the state of things with this PR right now.
I'm hoping to break everything in #26725 anyway 🤞

build: update configure for Node.js 12
41ba699 
Update supported level of gcc to 6.3.0 and clang to 8.0.0.

Refs: nodejs#26714

PR-URL: nodejs#26719
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
richardlau merged commit 41ba699 into nodejs:master Mar 22, 2019

richardlau commented Mar 22, 2019

Copy link
Copy Markdown
Member Author

Landed in 41ba699.

This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 21, 2019
Merged
Closed
richardlau mentioned this pull request Nov 8, 2019
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BridgeAR BridgeAR approved these changes
+2 more reviewers
refack refack approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL