FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: pass along errors from object instantiations by addaleax · Pull Request #25734 · nodejs/node · GitHub

/ node Public

src: pass along errors from object instantiations - #25734

Closed
addaleax wants to merge 7 commits into
nodejs:masterfrom
addaleax:new-instance-1
ConversationCommits (7)ChecksFiles changed
Closed

src: pass along errors from object instantiations#25734
addaleax wants to merge 7 commits into
nodejs:masterfrom
addaleax:new-instance-1

Conversation

addaleax commented Jan 27, 2019

Copy link
Copy Markdown
Member

Calling Function::NewInstance() can always fail in the presence of termination exceptions, so we need to check for error conditions when calling it.

This PR does not address all of those cases, but at least some of them.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Jan 27, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2403/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 27, 2019

addaleax commented Jan 28, 2019

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20393/

addaleax commented Jan 29, 2019

Copy link
Copy Markdown
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20409/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 29, 2019

addaleax commented Jan 29, 2019

Copy link
Copy Markdown
Member Author

Landed in 1a37fd6...8e6667f

addaleax closed this Jan 29, 2019
addaleax deleted the new-instance-1 branch January 29, 2019 19:08
addaleax added a commit that referenced this pull request Jan 29, 2019
src: pass along errors from PromiseWrap instantiation
5556975 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Jan 29, 2019
src: pass along errors from stream obj instantiation
4dbff09 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Jan 29, 2019
src: pass along errors from process obj instantiation
95571ac 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Jan 29, 2019
src: pass along errors from perf obj instantiation
77fa310 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Jan 29, 2019
src: pass along errors from KeyObject instantiation
6202096 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Jan 29, 2019
src: pass along errors from vm data wrapper creation
2c18d97 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Jan 29, 2019
src: pass along errors from i18n converter instantiation
8e6667f 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
src: pass along errors from stream obj instantiation
2928672 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
src: pass along errors from process obj instantiation
5add2b5 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
src: pass along errors from perf obj instantiation
ced4e71 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
src: pass along errors from KeyObject instantiation
8ee4810 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
src: pass along errors from vm data wrapper creation
deebf10 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
src: pass along errors from i18n converter instantiation
c095106 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos mentioned this pull request Jan 29, 2019
Merged
joyeecheung reviewed Jan 29, 2019
View reviewed changes
Comment thread src/env.cc
MaybeLocal<Object> Environment::CreateProcessObject(
const std::vector<std::string>& args,
const std::vector<std::string>& exec_args) {
if (*TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED(

joyeecheung Jan 29, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why is this part inside CreateProcessObject? (Or rather why is this method named CreateProcessObject?)

addaleax Jan 30, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@joyeecheung Because it’s the part that handles args and exec_args, that’s pretty much all the reason … also, I called it that because that’s what it mainly does, create + set up the process object?

addaleax added a commit to addaleax/node that referenced this pull request Jan 30, 2019
src: pass along errors from PromiseWrap instantiation
a29a712 
PR-URL: nodejs#25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax mentioned this pull request Jan 30, 2019
Closed
2 tasks
addaleax added a commit that referenced this pull request Feb 3, 2019
src: pass along errors from PromiseWrap instantiation
882902c 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

PR-URL: #25837
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung left review comments
jasnell jasnell approved these changes
+1 more reviewer
devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL