FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v11.x] src: pass along errors from PromiseWrap instantiation by addaleax · Pull Request #25837 · nodejs/node · GitHub

/ node Public

[v11.x] src: pass along errors from PromiseWrap instantiation - #25837

Closed
addaleax wants to merge 1 commit into
nodejs:v11.x-stagingfrom
addaleax:backport-promise-wrap-newinstance
ConversationCommits (1)ChecksFiles changed
Closed

[v11.x] src: pass along errors from PromiseWrap instantiation#25837
addaleax wants to merge 1 commit into
nodejs:v11.x-stagingfrom
addaleax:backport-promise-wrap-newinstance

Conversation

addaleax commented Jan 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Backport of one commit from #25734, with a minor conflict due to #23443 resolved.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

src: pass along errors from PromiseWrap instantiation
a29a712 
PR-URL: nodejs#25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

nodejs-github-bot commented Jan 30, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2462/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v11.x labels Jan 30, 2019
addaleax force-pushed the backport-promise-wrap-newinstance branch from 8cfe09a to a29a712 Compare January 30, 2019 23:35

addaleax commented Feb 3, 2019

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20554/

addaleax commented Feb 3, 2019

Copy link
Copy Markdown
Member Author

Landed in 882902c

addaleax added a commit that referenced this pull request Feb 3, 2019
src: pass along errors from PromiseWrap instantiation
882902c 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

PR-URL: #25837
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax closed this Feb 3, 2019
addaleax deleted the backport-promise-wrap-newinstance branch February 3, 2019 19:49
targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL