FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: skip test-cpu-prof in debug builds with code cache by joyeecheung · Pull Request #27308 · nodejs/node · GitHub

/ node Public

test: skip test-cpu-prof in debug builds with code cache - #27308

Closed
joyeecheung wants to merge 3 commits into
nodejs:masterfrom
joyeecheung:skip-debug
ConversationCommits (3)ChecksFiles changed
Closed

test: skip test-cpu-prof in debug builds with code cache#27308
joyeecheung wants to merge 3 commits into
nodejs:masterfrom
joyeecheung:skip-debug

Conversation

joyeecheung commented Apr 19, 2019

Copy link
Copy Markdown
Member

The CPU profiler crashes in debug builds when code cache is
enabled. Skip the test temporarily until it's fixed.

Refs: #27307

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test: skip test-cpu-prof in debug builds with code cache
8998165 
The CPU profiler crashes in debug builds when code cache is
enabled. Skip the test temporarily until it's fixed.

nodejs-github-bot commented Apr 19, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3302

nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 19, 2019

joyeecheung commented Apr 19, 2019

Copy link
Copy Markdown
Member Author

master: https://ci.nodejs.org/job/node-test-commit/27938/

nodejs-github-bot commented Apr 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22559/

addaleax approved these changes Apr 19, 2019
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I’m 👍 to fast-tracking if you want

joyeecheung commented Apr 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Fixed the linter and the skip message.

@addaleax Let's see if this is green in CI first..(it passes for me locally, previously it always crashed)

nodejs-github-bot commented Apr 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22561/

joyeecheung commented Apr 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI is green. Please thumb this up if you are +1 to fast tracking (this unbreaks debug builds on master)

@nodejs/testing

devsnek added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 19, 2019

joyeecheung commented Apr 19, 2019

Copy link
Copy Markdown
Member Author

Landed in b66f01d

joyeecheung added a commit that referenced this pull request Apr 19, 2019
test: skip test-cpu-prof in debug builds with code cache
b66f01d 
The CPU profiler crashes in debug builds when code cache is
enabled. Skip the test temporarily until it's fixed.

PR-URL: #27308
Refs: #27307
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
refack reviewed Apr 19, 2019
View reviewed changes
Comment thread test/sequential/test-cpu-prof.js

const common = require('../common');
if (process.features.debug &&
process.config.variables.node_code_cache_path === 'yes') {

refack Apr 19, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ATM this is not the best predicate for embedded code-cache...
I've submitted #27311 to fix the value, and this predicate (it could be any non '' value if combined with the previous manual embedding technique)

refack mentioned this pull request Apr 21, 2019
Merged
4 tasks
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
ZYSzys ZYSzys approved these changes
+2 more reviewers
refack refack left review comments
devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL