build: improve embedded code-cache detection - #27311
Merged
refack merged 1 commit intoApr 22, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This comment has been minimized.
2 tasks
mihalskiy
approved these changes
Apr 19, 2019
joyeecheung
approved these changes
Apr 19, 2019
joyeecheung
reviewed
Apr 19, 2019
Comment thread
test/sequential/test-cpu-prof.js
Outdated
refack
force-pushed
the
fix-config-code-cache-bug
branch
from
0606363 to
98deba3
Compare
April 19, 2019 21:59
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Added process.features.code_cache field based on compile time constant, and not build configuration. |
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
joyeecheung
reviewed
Apr 20, 2019
Comment thread
lib/internal/bootstrap/node.js
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Ping @nodejs/build-files @nodejs/process |
Sorry, something went wrong.
joyeecheung
approved these changes
Apr 20, 2019
richardlau
approved these changes
Apr 21, 2019
refack
force-pushed
the
fix-config-code-cache-bug
branch
from
f0b5677 to
cbf534c
Compare
April 21, 2019 13:35
This comment has been minimized.
BridgeAR
reviewed
Apr 21, 2019
refack
force-pushed
the
fix-config-code-cache-bug
branch
from
cbf534c to
4d81c09
Compare
April 21, 2019 19:39
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
PR-URL: nodejs#27311 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refack
force-pushed
the
fix-config-code-cache-bug
branch
from
4d81c09 to
5aaf666
Compare
April 22, 2019 18:49
This was referenced Apr 23, 2019
This was referenced Sep 12, 2024
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 10, 2025
PR-URL: nodejs#54982 Refs: nodejs@aa0308d Refs: nodejs@9010f5f Refs: nodejs@52a40e0 Refs: nodejs@b3ef289 Refs: nodejs#2564 Refs: nodejs#25819 Refs: nodejs#27311 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #27308
Checklist