deps: update ICU to 64.2 by ryzokuken · Pull Request #27361 · nodejs/node · GitHub

Release Date: April 17th

Fixes: #26388

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

/cc @srl295 @refack @targos 🎉

NOTE: This is required to make V8's canary work with Node.js again.

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3336

Unrelated license changes, please investigate.

Update the version of the bundled ICU (deps/icu-small) to ICU version 64.2 (Unicode 12, CLDR 35) Fixes: nodejs#26388

@richardlau @targos PTAL now.

Second commit LGTM.

RSLGTM for the first commit.

Suggested change

      
            - ICU, located at deps/icu, is licensed as follows:
          
            - ICU, located at deps/icu-small, is licensed as follows:

Update the LICENSE file and tools/icu/current_ver.dep file in order to finalize the upgrade to ICU 64.2

Great for doing this! Didn’t review yet ^ if you “make clean” and rerun the license gen it should change the license file to Be consistent

@srl295 fixed it already! Thanks.

🎉 Looks Great To Me!

filed #27369 (comment) to support sha512 in the current_ver.dep

Rubber stamp LGTM

Oh also, this is needed for Japanese Era (Reiwa) support

$ ./node -p "new Date('5/1/2019').toLocaleString('ja-u-ca-japanese', {era: 'long'})"
令和元年5月1日 0:00:00

CI: https://ci.nodejs.org/job/node-test-pull-request/22680/

CI: https://ci.nodejs.org/job/node-test-pull-request/22719/

Landed in 6bbb9eb...c80c414

Update the version of the bundled ICU (deps/icu-small) to ICU version 64.2 (Unicode 12, CLDR 35) Fixes: #26388 PR-URL: #27361 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Update the LICENSE file and tools/icu/current_ver.dep file in order to finalize the upgrade to ICU 64.2 PR-URL: #27361 Fixes: #26388 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Update the version of the bundled ICU (deps/icu-small) to ICU version 64.2 (Unicode 12, CLDR 35) Fixes: #26388 PR-URL: #27361 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Update the LICENSE file and tools/icu/current_ver.dep file in order to finalize the upgrade to ICU 64.2 PR-URL: #27361 Fixes: #26388 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Notable changes: * intl: * Update ICU to 64.2. This adds support for Japanese Era (Reiwa). #27361 * Fixes a bug in ICU that affected Node.js 12.0.0 in the case where `new Date().toLocaleString()` was called with a non-default locale. #27415 * C++ API: * Added an `Environment` overload of `EmitAsyncDestroy`. #27255 PR-URL: TODO

Notable changes: * intl: * Update ICU to 64.2. This adds support for Japanese Era (Reiwa). #27361 * Fixes a bug in ICU that affected Node.js 12.0.0 in the case where `new Date().toLocaleString()` was called with a non-default locale. #27415 * C++ API: * Added an overload of `EmitAsyncDestroy` that can be used during garbage collection. #27255 PR-URL: #27440

Yes, great work @ryzokuken and reviewers! Happy to see this landed before Reiwa starts.

Update the version of the bundled ICU (deps/icu-small) to ICU version 64.2 (Unicode 12, CLDR 35) Fixes: #26388 PR-URL: #27361 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Update the LICENSE file and tools/icu/current_ver.dep file in order to finalize the upgrade to ICU 64.2 PR-URL: #27361 Fixes: #26388 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Update the version of the bundled ICU (deps/icu-small) to ICU version 64.2 (Unicode 12, CLDR 35) Fixes: #26388 PR-URL: #27361 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Update the LICENSE file and tools/icu/current_ver.dep file in order to finalize the upgrade to ICU 64.2 PR-URL: #27361 Fixes: #26388 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Notable changes: - **deps**: - update ICU to 64.2 (Ujjwal Sharma) [#27361](#27361) - upgrade npm to 6.9.0 (Kat Marchán) [#26244](#26244) - upgrade openssl sources to 1.1.1b (Sam Roberts) [#26327](#26327) - upgrade to libuv 1.28.0 (cjihrig) [#27241](#27241) - **events**: - add once method to use promises with EventEmitter (Matteo Collina) [#26078](#26078) - **n-api**: - mark thread-safe function as stable (Gabriel Schulhof) [#25556](#25556) - **repl**: - support top-level for-await-of (Shelley Vohr) [#23841](#23841) - **zlib**: - add brotli support (Anna Henningsen) [#24938](#24938) PR-URL: #27514

ryzokuken requested review from refack and srl295 April 23, 2019 13:00

ryzokuken self-assigned this Apr 23, 2019

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 23, 2019

richardlau requested changes Apr 23, 2019

View reviewed changes

ryzokuken mentioned this pull request Apr 23, 2019

tools: update tools/license-builder.sh #27362

Merged

deps: update ICU to 64.2

b72fc90

Update the version of the bundled ICU (deps/icu-small) to ICU version 64.2 (Unicode 12, CLDR 35) Fixes: nodejs#26388

ryzokuken force-pushed the icu-64.2 branch from 937dea1 to e8977f5 Compare April 23, 2019 13:41

richardlau approved these changes Apr 23, 2019

View reviewed changes

targos reviewed Apr 23, 2019

View reviewed changes

deps: update LICENSE and tools/icu/current_ver.dep

e5bd726

Update the LICENSE file and tools/icu/current_ver.dep file in order to finalize the upgrade to ICU 64.2

ryzokuken force-pushed the icu-64.2 branch from e8977f5 to e5bd726 Compare April 23, 2019 14:04

srl295 reviewed Apr 23, 2019

View reviewed changes

Comment thread tools/icu/current_ver.dep

srl295 approved these changes Apr 23, 2019

View reviewed changes

srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Apr 23, 2019

srl295 mentioned this pull request Apr 23, 2019

build: allow icu download to use sha512 over md5 #27370

Closed

2 tasks

mhdawson approved these changes Apr 23, 2019

View reviewed changes

targos mentioned this pull request Apr 23, 2019

deps: update V8 to 7.5 #27375

Merged

addaleax added lts-watch-v10.x labels Apr 24, 2019

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 24, 2019

srl295 mentioned this pull request Apr 25, 2019

backport ICU-20575 to fix err/crasher in ICU 64.x #27418

Closed

refack mentioned this pull request Apr 25, 2019

deps: backport ICU-20558 to fix Intl crasher #27415

Closed

2 tasks

targos mentioned this pull request Apr 27, 2019

v12.1.0 proposal #27440

Merged

targos mentioned this pull request May 1, 2019

v10.16.0 proposal #27514

Merged

BethGriggs added land-on-v10.x and removed lts-watch-v10.x labels Jul 9, 2019

srl295 mentioned this pull request Sep 10, 2019

Time Zone Bug ('Antarctica/DumontDUrville') #28455

Closed

bnoordhuis mentioned this pull request Sep 19, 2019

Wrong Intl.DateTimeFormat output for zh-CN without year part #29596

Closed

BethGriggs removed the lts-watch-v8.x label Sep 19, 2019

	- ICU, located at deps/icu, is licensed as follows:
	- ICU, located at deps/icu-small, is licensed as follows:

deps: update ICU to 64.2 by ryzokuken · Pull Request #27361 · nodejs/node · GitHub

Uh oh!

Uh oh!

deps: update ICU to 64.2 - #27361

deps: update ICU to 64.2#27361ryzokuken wants to merge 2 commits intonodejs:masternodejs/node:masterfrom ryzokuken:icu-64.2ryzokuken/node:icu-64.2Copy head branch name to clipboard

Conversation

ryzokuken commented Apr 23, 2019

Checklist

Uh oh!

nodejs-github-bot commented Apr 23, 2019

Uh oh!

richardlau left a comment

Choose a reason for hiding this comment

Uh oh!

ryzokuken commented Apr 23, 2019

Uh oh!

richardlau left a comment

Choose a reason for hiding this comment

Uh oh!

targos Apr 23, 2019

Choose a reason for hiding this comment

Uh oh!

srl295 commented Apr 23, 2019 via email

Uh oh!

ryzokuken commented Apr 23, 2019

Uh oh!

Uh oh!

srl295 left a comment

Choose a reason for hiding this comment

Uh oh!

srl295 commented Apr 23, 2019

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

srl295 commented Apr 23, 2019

Uh oh!

nodejs-github-bot commented Apr 24, 2019

Uh oh!

nodejs-github-bot commented Apr 25, 2019

Uh oh!

targos commented Apr 25, 2019

Uh oh!

shinnn commented Apr 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

deps: update ICU to 64.2#27361
ryzokuken wants to merge 2 commits into
nodejs:masterfrom
ryzokuken:icu-64.2