FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: eos more accurate writable and readable detection by ronag · Pull Request #29409 · nodejs/node · GitHub

/ node Public

stream: eos more accurate writable and readable detection - #29409

Closed
ronag wants to merge 2 commits into
nodejs:masterfrom
nxtedition:eos-writable-readable
ConversationCommits (2)ChecksFiles changed
Closed

stream: eos more accurate writable and readable detection#29409
ronag wants to merge 2 commits into
nodejs:masterfrom
nxtedition:eos-writable-readable

Conversation

ronag commented Sep 2, 2019

Copy link
Copy Markdown
Member

The value of stream.readable and stream.writable should not
be used to detect whether a stream is Writable or Readable.

Refs: #29395

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

cclauss commented Sep 2, 2019

Copy link
Copy Markdown
Contributor

https://travis-ci.com/nodejs/node/jobs/230132767#L254

ronag added 2 commits September 3, 2019 13:46
stream: eos more accurate writable and readable detection
a26c3a0 
The value of stream.readable and stream.writable should not
be used to detect whether a stream is Writable or Readable.

Refs: nodejs#29395
fixup: linting
5b6e33a
ronag force-pushed the eos-writable-readable branch from afe332c to 5b6e33a Compare September 3, 2019 11:47

Fishrock123 commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

Might it be useful to publicly expose these?

ronag commented Sep 5, 2019

Copy link
Copy Markdown
Member Author

@Fishrock123: Something like?

const { isReadable, isWritable } = require('stream');

Fishrock123 commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

@ronag Yes, although I'd like to hear others chime in on the stability of such functions.

Fishrock123 added the stream Issues and PRs related to the stream subsystem. label Sep 6, 2019

Trott commented Sep 7, 2019

Copy link
Copy Markdown
Member

@nodejs/streams

mcollina approved these changes Sep 7, 2019
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nodejs-github-bot commented Sep 12, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25440/

nodejs-github-bot commented Sep 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25467/

ronag commented Sep 20, 2019

Copy link
Copy Markdown
Member Author

@Trott: This looks ready?

Trott pushed a commit that referenced this pull request Sep 22, 2019
stream: use more accurate end-of-stream writable and readable detection
8709a40 
The value of stream.readable and stream.writable should not
be used to detect whether a stream is Writable or Readable.

Refs: #29395
PR-URL: #29409
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott commented Sep 22, 2019

Copy link
Copy Markdown
Member

Landed in 8709a40

Trott closed this Sep 22, 2019

targos commented Sep 23, 2019

Copy link
Copy Markdown
Member

Should this be backported to v12.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

ronag commented Sep 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

@targos: Never done it before but I will take a look. Will try to have something ready this week.

ronag commented Sep 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

I'd very much like to have this merged and included in such a backport, #29664.

BethGriggs mentioned this pull request Oct 21, 2019
Merged

MylesBorins commented Jan 10, 2020

Copy link
Copy Markdown
Contributor

quick ping re: backport

sxa commented Jan 13, 2020

Copy link
Copy Markdown
Member

@MylesBorins Coincidentally I started looking at backporting this one on Friday - PR ready now

sxa pushed a commit to sxa/node that referenced this pull request Jan 13, 2020
stream: use more accurate end-of-stream writable and readable detection
6c41057 
The value of stream.readable and stream.writable should not
be used to detect whether a stream is Writable or Readable.

PR-URL: nodejs#29409
Backport-PR-URL: nodejs#31345
targos pushed a commit that referenced this pull request Jan 14, 2020
stream: use more accurate end-of-stream writable and readable detection
536d088 
The value of stream.readable and stream.writable should not
be used to detect whether a stream is Writable or Readable.

Refs: #29395
PR-URL: #29409
Backport-PR-URL: #31345
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
stream: use more accurate end-of-stream writable and readable detection
369b7c2 
The value of stream.readable and stream.writable should not
be used to detect whether a stream is Writable or Readable.

Refs: #29395
PR-URL: #29409
Backport-PR-URL: #31345
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes

Assignees

No one assigned

Labels

stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL