FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: remove ambiguous code by ronag · Pull Request #29664 · nodejs/node · GitHub

/ node Public

stream: remove ambiguous code - #29664

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:stream-eos-dead
ConversationCommits (1)ChecksFiles changed
Closed

stream: remove ambiguous code#29664
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:stream-eos-dead

Conversation

ronag commented Sep 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

This cleans up some ambiguous code. I don't believe this actually causes any observable change of behaviour.

writable, readable is supposed to indicate the type of the stream, which does not change... this PR makes the code less confusing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

mscdex commented Sep 23, 2019

Copy link
Copy Markdown
Contributor

s/ambigious/ambiguous/ in commit message

ronag changed the title stream: remove ambigious code stream: remove ambiguous code Sep 23, 2019

ronag commented Sep 23, 2019

Copy link
Copy Markdown
Member Author

Not sure what you meant. But I'm guess it's the misspelling. Fixed.

ronag mentioned this pull request Sep 23, 2019
Closed
4 tasks

ronag commented Sep 23, 2019

Copy link
Copy Markdown
Member Author

@mcollina

mcollina requested changes Sep 23, 2019
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

cc @mafintosh

Comment thread lib/internal/streams/end-of-stream.js
Comment thread lib/internal/streams/end-of-stream.js
mcollina approved these changes Sep 27, 2019
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mcollina commented Sep 27, 2019

Copy link
Copy Markdown
Member

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3939/

JungMinu pushed a commit that referenced this pull request Sep 29, 2019
stream: remove ambiguous code
ce62e96 
PR-URL: #29664
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

JungMinu commented Sep 29, 2019

Copy link
Copy Markdown
Member

Landed in ce62e96

JungMinu closed this Sep 29, 2019
BridgeAR added backport-requested-v12.x stream Issues and PRs related to the stream subsystem. labels Oct 9, 2019

BridgeAR commented Oct 9, 2019

Copy link
Copy Markdown
Member

@ronag I guess this depends on other PRs that need backporting first? This currently causes conflicts that are not obvious to resolve. Would you be so kind and check if other PRs need backporting first and add that as well / open a backport if you think that's useful here?

ronag commented Oct 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

This is probably about to be reverted in #29717 (comment).

I will look into backporting this if/when this becomes relevant again.

MylesBorins commented Jan 10, 2020

Copy link
Copy Markdown
Contributor

quick ping re: backport

ronag added a commit to nxtedition/node that referenced this pull request Jan 18, 2020
stream: remove ambiguous code
ba74fd8 
PR-URL: nodejs#29664
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
sxa pushed a commit to sxa/node that referenced this pull request Jan 24, 2020
[v12.x backport] stream: remove ambiguous code
8ff774e 
PR-URL: nodejs#29664
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

sxa commented Jan 24, 2020

Copy link
Copy Markdown
Member

@MylesBorins In view of 8c60685#diff-009356850b536cab27b019ba8ad15e72 are you sure this should be backported?

MylesBorins commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

Seems like it shouldn't

kissofire mentioned this pull request Feb 25, 2021
Open
aliceUnhinged613 mentioned this pull request Feb 25, 2021
Open
ron-a20 mentioned this pull request Feb 26, 2021
Open
sitedata mentioned this pull request Feb 26, 2021
Open
meghasfdc mentioned this pull request Feb 26, 2021
Open
137717unity mentioned this pull request Feb 26, 2021
Open
Rednickle mentioned this pull request Feb 26, 2021
Open
This was referenced May 5, 2021
Open
Closed
Closed
Open
Open
snyk-bot mentioned this pull request May 26, 2021
Open
aliceUnhinged613 mentioned this pull request Oct 30, 2022
Open
137717unity mentioned this pull request Oct 30, 2022
Open
molllyn1 mentioned this pull request Oct 30, 2022
Open
kissofire mentioned this pull request Oct 30, 2022
Open
wedataintelligence mentioned this pull request Oct 30, 2022
Open
snyk-bot mentioned this pull request Oct 31, 2022
Open
ron-a20 mentioned this pull request Oct 31, 2022
Open
snyk-bot mentioned this pull request Oct 31, 2022
Open
snyk-bot mentioned this pull request Nov 10, 2022
Open
kissofire mentioned this pull request Dec 6, 2023
Open
137717unity mentioned this pull request Dec 6, 2023
Open
ron-a20 mentioned this pull request Dec 6, 2023
Open
aliceUnhinged613 mentioned this pull request Dec 6, 2023
Open
wedataintelligence mentioned this pull request Dec 7, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
JungMinu JungMinu approved these changes

Assignees

No one assigned

Labels

stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL