| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
//cc @nodejs/modules-active-members |
Sorry, something went wrong.
|
The three failing tests in this PR are:
|
Sorry, something went wrong.
|
Adding WIP label based on PR description. Feel free to remove when appropriate, swap out with blocked label, or whatever. No strong opinions here. Just seems like the right thing to me. (The WIP label helps me in my workflow with the repository, so it's not just cosmetic for me, if that matters. But again, no strong opinions on this particular PR in that regard.) |
Sorry, something went wrong.
|
On @joyeecheung's advice I've gone ahead and changed the way the async bootstrap works. Instead of always applying an async bootstrap, the async bootstrap and all promises associated will only apply lazily when the ESM loader is actually in use. This way loading CommonJS retains a fully sync bootstrap that is completely backwards compatible with no timings changes or task queue differences. This also removes the dependence of this work on #29848. All tests are now passing! Further review welcome. |
Sorry, something went wrong.
|
I've split out the bootstrap changes into a separate PR at #29937, and based this unflagging to that PR for a simpler diff. |
Sorry, something went wrong.
|
We likely want #29974 to land as well |
Sorry, something went wrong.
|
@nodejs/modules anyone have an issue with renaming --loader to --experimental-loader before we land this? I can open a PR (and 12.x backport), but I'd be concerned with unflagging and not being explicit about this |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR unflags the --experimental-modules support making modules on-by-default, while remaining backwards-compatible with the current runMain.
This PR should only land after the remaining PRs have been fully considered:
In addition to:
Checklist