FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

esm: unflag --experimental-exports by guybedford · Pull Request #29867 · nodejs/node · GitHub

/ node Public

esm: unflag --experimental-exports - #29867

Closed
guybedford wants to merge 1 commit into
nodejs:masterfrom
guybedford:unflag-exports
ConversationCommits (1)ChecksFiles changed
Closed

esm: unflag --experimental-exports#29867
guybedford wants to merge 1 commit into
nodejs:masterfrom
guybedford:unflag-exports

Conversation

guybedford commented Oct 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

This removes the experimental --experimental-exports flag to make the support on by default.

This PR should not land until we have:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 7, 2019
guybedford mentioned this pull request Oct 7, 2019
Closed
14 tasks
guybedford added the esm Issues and PRs related to the ECMAScript Modules implementation. label Oct 7, 2019

guybedford commented Oct 7, 2019

Copy link
Copy Markdown
Contributor Author

//cc @nodejs/modules-active-members

Trott added the wip Issues and PRs that are still a work in progress. label Oct 9, 2019

Trott commented Oct 9, 2019

Copy link
Copy Markdown
Member

Added the WIP label based on the PR description (although feel free to swap it out for the blocked label if that's more appropriate).

mhdawson mentioned this pull request Oct 9, 2019
Closed
guybedford removed the wip Issues and PRs that are still a work in progress. label Oct 9, 2019

guybedford commented Oct 9, 2019

Copy link
Copy Markdown
Contributor Author

We got resolution in today's meeting to merge this, with the behaviour still flagged by --experimental-modules, thus making it part of the baseline modules features.

We just need core collaborator approvals to land further.

hybrist approved these changes Oct 9, 2019
View reviewed changes

hybrist left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, as discussed in the WG meeting.

nodejs-github-bot commented Oct 10, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25946/

guybedford added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 10, 2019

guybedford commented Oct 10, 2019

Copy link
Copy Markdown
Contributor Author

Can I get a further review here from someone? Would be great to land soon to prepare for #29866.

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Oct 10, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25947/

guybedford commented Oct 10, 2019

Copy link
Copy Markdown
Contributor Author

Thanks @Trott just running a final CI with the latest rebase.

Trott reviewed Oct 10, 2019
View reviewed changes
Comment thread doc/api/cli.md Outdated

nodejs-github-bot commented Oct 10, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25948/

Trott commented Oct 10, 2019

Copy link
Copy Markdown
Member

Landed in b798f64

Trott closed this Oct 10, 2019
Trott pushed a commit that referenced this pull request Oct 10, 2019
esm: unflag --experimental-exports
b798f64 
PR-URL: #29867
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ljharb mentioned this pull request Oct 11, 2019
Merged
BethGriggs mentioned this pull request Oct 21, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
esm: unflag --experimental-exports
808a302 
PR-URL: #29867
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 10, 2019
molllyn1 mentioned this pull request Nov 5, 2022
Open
snyk-bot mentioned this pull request Nov 5, 2022
Open
baby636 mentioned this pull request Nov 5, 2022
Open
ron-a20 mentioned this pull request Nov 5, 2022
Open
wedataintelligence mentioned this pull request Nov 5, 2022
Open
kissofire mentioned this pull request Nov 5, 2022
Open
aliceUnhinged613 mentioned this pull request Dec 25, 2022
Open
wedataintelligence mentioned this pull request Dec 25, 2022
Open
kissofire mentioned this pull request Dec 25, 2022
Open
molllyn1 mentioned this pull request Dec 26, 2022
Open
137717unity mentioned this pull request Dec 26, 2022
Open
baby636 mentioned this pull request Dec 26, 2022
Open
snyk-bot mentioned this pull request Dec 26, 2022
Open
ron-a20 mentioned this pull request Oct 1, 2023
Open
aliceUnhinged613 mentioned this pull request Oct 1, 2023
Open
kissofire mentioned this pull request Oct 1, 2023
Open
wedataintelligence mentioned this pull request Oct 2, 2023
Open
molllyn1 mentioned this pull request Oct 2, 2023
Open
137717unity mentioned this pull request Oct 2, 2023
Open
baby636 mentioned this pull request Oct 2, 2023
Open
baby636 mentioned this pull request Jan 2, 2024
Open
ron-a20 mentioned this pull request Jan 9, 2024
Open
kissofire mentioned this pull request Jan 9, 2024
Open
aliceUnhinged613 mentioned this pull request Jan 9, 2024
Open
molllyn1 mentioned this pull request Jan 9, 2024
Open
137717unity mentioned this pull request Jan 9, 2024
Open
wedataintelligence mentioned this pull request Jan 9, 2024
Open
baby636 mentioned this pull request Jan 9, 2024
Open
baby636 mentioned this pull request Mar 19, 2024
Open
baby636 mentioned this pull request Mar 27, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
hybrist hybrist approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL