FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update remark-preset-lint-node to 1.10.1 by Trott · Pull Request #29982 · nodejs/node · GitHub

/ node Public

tools: update remark-preset-lint-node to 1.10.1 - #29982

Merged
Trott merged 2 commits into
nodejs:masterfrom
Trott:update-preset-to-1.10.1
Oct 15, 2019
ConversationCommits (2)ChecksFiles changed
Merged

tools: update remark-preset-lint-node to 1.10.1#29982
Trott merged 2 commits into
nodejs:masterfrom
Trott:update-preset-to-1.10.1

Conversation

Trott commented Oct 15, 2019

Copy link
Copy Markdown
Member

This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks @nschonni!).

Update other dependencies while at it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 15, 2019

Trott commented Oct 15, 2019

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3993/

nschonni mentioned this pull request Oct 15, 2019
Merged
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 15, 2019

Trott commented Oct 15, 2019

Copy link
Copy Markdown
Member Author

I don't want lint violations to land in the docs while this waits for the 48 hours, so I'd like to fast track. Collaborators, please 👍 here to approve.

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 15, 2019
Trott added 2 commits October 15, 2019 13:25
doc: update vm.md for link linting
c4de76f 
Update vm.md for link linting rules that are about to be applied. Define
an undefined link reference. Escape non-link text that uses `[` and `]`.

PR-URL: nodejs#29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tools: update remark-preset-lint-node to 1.10.1
90b5f1b 
This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks nschonni!).

Update other dependencies while at it.

PR-URL: nodejs#29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott force-pushed the update-preset-to-1.10.1 branch from cfccf45 to 90b5f1b Compare October 15, 2019 20:26

Trott commented Oct 15, 2019

Copy link
Copy Markdown
Member Author

Landed in f4f856b...90b5f1b

Trott merged commit 90b5f1b into nodejs:master Oct 15, 2019
BethGriggs mentioned this pull request Oct 21, 2019
Merged

targos commented Nov 8, 2019

Copy link
Copy Markdown
Member

Depends on #29864 to land on v12.x.

aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 7, 2020
doc: update vm.md for link linting
adf9fe0 
Update vm.md for link linting rules that are about to be applied. Define
an undefined link reference. Escape non-link text that uses `[` and `]`.

PR-URL: nodejs#29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 7, 2020
tools: update remark-preset-lint-node to 1.10.1
4442359 
This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks nschonni!).

Update other dependencies while at it.

PR-URL: nodejs#29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 mentioned this pull request Jan 7, 2020
Closed
2 tasks
aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 8, 2020
doc: update vm.md for link linting
ba2725c 
Update vm.md for link linting rules that are about to be applied. Define
an undefined link reference. Escape non-link text that uses `[` and `]`.

PR-URL: nodejs#29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 8, 2020
tools: update remark-preset-lint-node to 1.10.1
3877a77 
This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks nschonni!).

Update other dependencies while at it.

PR-URL: nodejs#29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jan 8, 2020
doc: update vm.md for link linting
0d43135 
Update vm.md for link linting rules that are about to be applied. Define
an undefined link reference. Escape non-link text that uses `[` and `]`.

PR-URL: #29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jan 8, 2020
tools: update remark-preset-lint-node to 1.10.1
dbb4e2a 
This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks nschonni!).

Update other dependencies while at it.

PR-URL: #29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
doc: update vm.md for link linting
30edcc0 
Update vm.md for link linting rules that are about to be applied. Define
an undefined link reference. Escape non-link text that uses `[` and `]`.

PR-URL: #29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
tools: update remark-preset-lint-node to 1.10.1
b09eda5 
This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks nschonni!).

Update other dependencies while at it.

PR-URL: #29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
Trott deleted the update-preset-to-1.10.1 branch January 13, 2022 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL