module: fix dynamic import from eval - #30624
Closed
coreyfarrell wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
devsnek
approved these changes
Nov 25, 2019
yorkie
reviewed
Nov 25, 2019
Comment thread
lib/internal/modules/esm/loader.js
Outdated
coreyfarrell
force-pushed
the
eval-dynamic-import
branch
from
9651517 to
e96ebc2
Compare
November 25, 2019 14:44
yorkie
approved these changes
Nov 25, 2019
yorkie
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'm not sure what to do here, it doesn't look like the crash is caused by my change? |
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
coreyfarrell
force-pushed
the
eval-dynamic-import
branch
from
e96ebc2 to
2d0c869
Compare
November 30, 2019 20:24
bcoe
reviewed
Nov 30, 2019
Comment thread
lib/internal/process/execution.js
Outdated
bcoe
suggested changes
Nov 30, 2019
Comment thread
lib/internal/process/execution.js
Outdated
Comment thread
lib/internal/process/execution.js
Outdated
bcoe
approved these changes
Dec 5, 2019
Copy link
Copy Markdown
Contributor
|
@coreyfarrell @guybedford this looks quite reasonable to me; @coreyfarrell when you have a moment, want to work on debugging the Travis tests? at which point I can kick off ci/cd? |
Sorry, something went wrong.
coreyfarrell
force-pushed
the
eval-dynamic-import
branch
from
231b8c3 to
523c187
Compare
December 5, 2019 19:33
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This allows dynamic import to work from CLI `--eval` with or without `--input-type=module`. Fixes: nodejs#30591
coreyfarrell
force-pushed
the
eval-dynamic-import
branch
from
523c187 to
bcc0331
Compare
December 6, 2019 00:40
This comment has been minimized.
bcoe
approved these changes
Dec 6, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
bcoe
approved these changes
Dec 7, 2019
bcoe
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
It looks like the most recent test run was successful, I am going to go ahead and land this.
Sorry, something went wrong.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows dynamic import to work from CLI --eval with or without
--input-type=module.
Fixes: #30591
Checklist