v13.4.0 proposal by MylesBorins · Pull Request #30937 · nodejs/node · GitHub

2019-12-17, Version 13.4.0 (Current), @MylesBorins

Notable Changes

Coming Soon

Commits

[1c4b2f15d9] - assert,util: stricter type comparison using deep equal comparisons (Ruben Bridgewater) #30764
[78eaf50693] - benchmark: improve --filter pattern matching (Matheus Marchini) #29987
[ad4d52d1b5] - benchmark: add more util inspect and format benchmarks (Ruben Bridgewater) #30767
[d90815d08e] - build: on Android, use android log library to print stack traces (Giovanni Campagna) #29388
[d1c4fccde2] - build: fix library version and compile flags on Android (Giovanni Campagna) #29388
[dfd3a4d6c1] - (SEMVER-MINOR) build: add flag to enable pointer compression (Matteo Collina) #30463
[3d05d4beea] - build: ease DragonFlyBSD build (David Carlier) #30201
[43e947a155] - build: remove (almost) unused macros/constants (Benjamin Coe) #30755
[0379fb65c1] - deps: update npm to 6.13.4 (Isaac Z. Schlueter) #30904
[13fe9f7cc8] - deps: update uvwasi (Anna Henningsen) #30745
[ca47f72868] - deps: upgrade to libuv 1.34.0 (Colin Ihrig) #30783
[458860691c] - deps: fix OPENSSLDIR on Windows (Shigeki Ohtsu) #29456
[b3ae532392] - doc: clarify build support text (Rich Trott) #30899
[8bf0da6c93] - doc: edit colorMode information (Rich Trott) #30887
[df9df1883e] - doc: fix argument type of setAAD (Tobias Nießen) #30863
[9d1c793ceb] - doc: clarify Tier 2 implications in BUILDING.md (Rich Trott) #30866
[1cce00073e] - doc: add code example to inspector.url() method (Juan José Arboleda) #29496
[93ca4f4098] - doc: deprecate http finished (Robert Nagy) #28679
[0022d7544a] - doc: improve doc Http2Stream: FrameError, Timeout and Trailers (dev-313) #30373
[2123d53c28] - doc: include line/cursor in readline documentation (Jeremy Albright) #30667
[1baa6ab075] - doc: improve napi formatting (Ruben Bridgewater) #30772
[1d5c4e21de] - doc: add documentation about node_mksnapshot and mkcodecache (Joyee Cheung) #30773
[67823e8fc4] - doc: remove imprecise and redundant testing text (Rich Trott) #30763
[7cb84fdbe5] - doc: remove usage of "Node" in favor of "Node.js" (Rich Trott) #30758
[510eb3a6eb] - doc: revise addons introduction for brevity and clarity (Rich Trott) #30756
[543bf9d8ea] - doc: fix up N-API doc (NickNaso) #30656
[2c0f1edfd5] - doc: adds assert doc for strict mode with pointer to strict equality (Shobhit Chittora) #30486
[9428304d4a] - doc: Buffer.toString(): add note about invalid data (Jan-Philip Gehrcke) #30706
[8369562757] - doc: clarify text about using 'session' event for compatibility (Rich Trott) #30746
[145f881ff9] - doc: update status of Python 3 support (Michael Dawson) #30722
[bbbba76f2c] - doc,benchmark: move benchmark guide to benchmark directory (Rich Trott) #30781
[eb4f443a5a] - esm: make specifier flag clearly experimental (Myles Borins) #30678
[220a6001c6] - (SEMVER-MINOR) events: add captureRejection option (Matteo Collina) #27867
[6c07a72833] - fs: synchronize close with other I/O for streams (Anna Henningsen) #30837
[18758ef183] - fs: retry unlink operations in rimraf (Colin Ihrig) #30569
[5e98de1751] - fs: only operate on buffers in rimraf (Colin Ihrig) #30569
[7e1dee3347] - fs: reduce unnecessary sync rimraf retries (Colin Ihrig) #30785
[5523950b47] - fs: add synchronous retries to rimraf (Colin Ihrig) #30785
[60b1e1ad61] - fs: fix existsSync for invalid symlink at win32 (Rongjian Zhang) #30556
[daca0780b1] - (SEMVER-MINOR) http: llhttp opt-in insecure HTTP header parsing (Sam Roberts) #30567
[334d4f6256] - (SEMVER-MINOR) http: add captureRejection support to OutgoingMessage (Matteo Collina) #27867
[33a6bf3a83] - (SEMVER-MINOR) http: implement capture rejections for 'request' event (Matteo Collina) #27867
[822fb00dbe] - http2: forward debug message in debugStreamObj (Denys Otrishko) #30840
[d17ea8f584] - http2: track nghttp2-allocated memory in heap snapshot (Anna Henningsen) #30745
[8a9f57d0d5] - http2: use shared memory tracking implementation (Anna Henningsen) #30745
[71bb026e0c] - http2: streamline OnStreamRead streamline memory accounting (Denys Otrishko) #30351
[3840abed11] - http2: small clean up in OnStreamRead (Denys Otrishko) #30351
[c3ac4c85a5] - (SEMVER-MINOR) http2: implement capture rection for 'request' and 'stream' events (Matteo Collina) #27867
[d3f0dd2148] - inspector: do not access queueMicrotask from global (Michaël Zasso) #30732
[71c6d44efa] - lib: enforce use of BigInt from primordials (Michaël Zasso) #30882
[64ab5c9c84] - lib: replace Symbol.iterator by SymbolIterator (Sebastien Ahkrin) #30859
[39898a9db4] - lib: replace every Symbol.for by SymbolFor primordials (Sebastien Ahkrin) #30857
[0a34fcb086] - lib: replace var with let/const (jens-cappelle) #30384
[af014170a7] - lib: replace Symbol global by the primordials Symbol (Sebastien Ahkrin) #30737
[2c439bb8ad] - lib: add parent to ERR_UNKNOWN_FILE_EXTENSION (qualitymanifest) #30728
[d9d64754f9] - lib: add warning on dynamic import es modules (Juan José Arboleda) #30720
[325128e469] - lib: delay access to CLI option to pre-execution (Joyee Cheung) #30778
[94f237e5ac] - lib,test: improves ERR_REQUIRE_ESM message (Juan José Arboleda) #30694
[e61f4ead93] - module: conditional exports import condition (Guy Bedford) #30799
[8e16093b64] - module: fix require in node repl (Yongsheng Zhang) #30835
[d4aa656d57] - module: fix dynamic import from eval (Corey Farrell) #30624
[a7ec78f34e] - module: fixup lint and test regressions (Guy Bedford) #30802
[bd2f1270f7] - module: ignore resolution failures for inspect-brk (Maël Nison) #30336
[851f3135ab] - module: add warnings for experimental flags (Rongjian Zhang) #30617
[123327d4c1] - net: remove duplicate _undestroy (Robert Nagy) #30833
[4eecee089d] - (SEMVER-MINOR) net: implement capture rejections for 'connection' event (Matteo Collina) #27867
[2f1ae4f2bf] - readline: eagerly load string_decoder (Ruben Bridgewater) #30807
[e551c169b8] - (SEMVER-MINOR) repl: support previews by eager evaluating input (Ruben Bridgewater) #30811
[c440f3fa3d] - repl: use better uncaught exceptions indicator (Ruben Bridgewater) #29676
[de368200f3] - src: accept single argument in getProxyDetails (Ruben Bridgewater) #30858
[60886036c9] - src: fix the false isatty() issue on IBMi (Xu Meng) #30829
[7ed867dddb] - src: improve checked uv loop close output (Anna Henningsen) #30814
[041daaa273] - src: port memory-tracking allocator from QUIC repo (Anna Henningsen) #30745
[ccf0917aef] - src: don't use deprecated OpenSSL APIs (Rosen Penev) #30812
[8ad53ab2b7] - src: free preopen memory in WASI::New() (Colin Ihrig) #30809
[e6e379ea41] - src: use checked allocations in WASI::New() (Colin Ihrig) #30809
[838ae10a9b] - src: delete redundant method in node_dir.h (gengjiawen) #30747
[66db8746c7] - src: remove redundant cast in node_dir.cc (gengjiawen) #30747
[cb69ff47f6] - src: improve node_crypto.cc memory allocation (Priyanka Kore) #30751
[b51b26ffef] - src: fix node_dir.cc memory allocation (Priyanka Kore) #30750
[89bc571490] - (SEMVER-MINOR) stream: add support for captureRejection option (Matteo Collina) #27867
[1b534d571a] - test: work around ENOTEMPTY when cleaning tmp dir (Ben Noordhuis) #30849
[eb6e32c2fc] - test: disable colorMode in test-console-group (Rich Trott) #30886
[5f42b1fc6b] - test: assert: fix deepStrictEqual comparing a real array and fake array (Jordan Harband) #30743
[ce21fc7154] - test: wait for stream close before writing to file (Anna Henningsen) #30836
[cc4a6ed645] - test: use fs rimraf to refresh tmpdir (Colin Ihrig) #30569
[5ae3a858f7] - test: refactor test-accessor-properties (himself65) #29943
[97e0efeedf] - test: scale keepalive timeouts for slow machines (Ben Noordhuis) #30834
[305e45a041] - test: mark tests as flaky (João Reis) #30848
[4dc9d8db13] - test: mark addons/openssl-bindings/test flaky on arm (Richard Lau) #30838
[25e3696a07] - test: improve WASI options validation (Rich Trott) #30800
[a574cb0ab9] - test: remove common.busyLoop() (Colin Ihrig) #30787
[3557659afb] - test: run more assert tests (Ruben Bridgewater) #30764
[5067463f3c] - test: use callback arguments in getconnections test (Rich Trott) #30775
[30756e36e7] - test: improve wasi test coverage (Rich Trott) #30770
[fb31ab52c0] - test: simplify tmpdir import in wasi tests (Rich Trott) #30770
[55a270b583] - test: remove duplicate entries from root.status (Richard Lau) #30769
[54a266c878] - test: increase debugging information in subprocess test (Rich Trott) #30761
[a0fa327365] - test: use block-scoping in test-net-server-address (Rich Trott) #30754
[9bd5c72104] - test: move test-child-process-fork-getconnections to parallel (Rich Trott) #30749
[50ab1fa013] - test: change common.PORT to arbitrary port (Rich Trott) #30749
[255cd7e572] - (SEMVER-MINOR) tls: expose IETF name for current cipher suite (Sam Roberts) #30637
[5ad3efbfb3] - (SEMVER-MINOR) tls: implement capture rejections for 'secureConnection' event (Matteo Collina) #27867
[5203ffb2f4] - tools: update link to google styleguide for cpplint (Daniel Bevenius) #30876
[1ed1a645f2] - tools: use CC instead of CXX when pointing to gcc (Milad Farazmand) #30817
[2b687af852] - tools: update remark-preset-lint-node to 1.11.0 (Rich Trott) #30789
[0cb7720dd8] - tools: update icu to 65.1 (Albert Wang) #30232
[7b9400ce63] - tools: update ESLint to 6.7.2 (Rich Trott) #30762
[5ab3ca4f96] - url: declare iterator inside loop (Trivikram Kamat) #30509
[dc69cbeb05] - util: add internal sleep() function (Colin Ihrig) #30787
[3898b2387b] - util: never trigger any proxy traps using format() (Ruben Bridgewater) #30767
[eeaeb51dcc] - util: improve performance inspecting proxies (Ruben Bridgewater) #30767
[608d720834] - (SEMVER-MINOR) util: add more predefined color codes to inspect.colors (Ruben Bridgewater) #30659
[77ffd5482d] - (SEMVER-MINOR) util: improve inspect's customInspect performance (Ruben Bridgewater) #30659
[14269d15cf] - wasi: use memory-tracking allocator (Anna Henningsen) #30745
[71d43a5569] - (SEMVER-MINOR) worker: add argv constructor option (legendecas) #30559

PR-URL: #27867 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Change common.PORT to arbitrary port in test-child-process-fork-getconnections to prepare for moving that test from sequential to parallel. PR-URL: #30749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Now that the test uses an open port assigned by the operating system rather than a hardcoded common.PORT, it can be moved to parallel. PR-URL: #30749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support. PR-URL: #30722 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Use block-scoping in test-net-server-address. This also allows us to easily rename some identifiers that were not camelCase. PR-URL: #30754 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #30750 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

This avoids heap allocations in common cases PR-URL: #30751 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #30747 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #30746 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #30706 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

OpenSSL has its own legacy names, but knowing the IETF name is useful when trouble-shooting, or looking for more information on the cipher. PR-URL: #30637 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

A convenience option to populate `process.argv` in worker threads. PR-URL: #30559 Fixes: #30531 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

Fixes: #30538 PR-URL: #30556 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: #30485 PR-URL: #30486 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

PR-URL: #30656 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #30756 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

In accordance with the Style Guide, remove "Node" in favor of "Node.js". A lint rule for this is forthcoming. PR-URL: #30758 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Grab it from the internal module where it's defined instead. PR-URL: #30732 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: #25988 (comment) PR-URL: #30761 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #30762 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

`--es-module-specifier-resolution` is the only flagged portion of the ESM implementation that does not have the word experimental in the flag name. This commit changes the flag to: `--experimental-specifier-resolution` `--es-module-specifier-resolution` remains as an alias for backwards compatibility but it is no longer documented. PR-URL: #30678 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

PR-URL: #30769 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

PR-URL: #30617 Fixes: #30600 Reviewed-By: Guy Bedford <guybedford@gmail.com>

Just so notable changes are not forgotten.

If this is going to be the security release, the commit message must have this line after the title:

This is a security release.

(And for those doing the security release (@nodejs/releasers ?) the security release will probably need to also include the recent commits @joaocgreis has added for the builds to work on Windows on the CI.)

001d250 is necessary to run CI. If the security release can only have one commit, I don't see a problem with running CI on a temporary branch that floats this commit on top of the release. The same for LTS branches - this cherry-picks cleanly into v12, but v10 and v8 have slightly different commits.

The other commits are not as essential, but the -native job turns yellow instead of red on cctest failures.

This is a security release. This release includes a single commit, an update to npm to 6.13.4. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: - update npm to 6.13.4 #30904 - update uvwasi (Anna Henningsen) #30745 - upgrade to libuv 1.34.0 (Colin Ihrig) #30783 * doc: - docs deprecate http finished (Robert Nagy) #28679 * events: - add captureRejection option (Matteo Collina) #27867 * http: - add captureRejection support (Matteo Collina) #27867 - llhttp opt-in insecure HTTP header parsing (Sam Roberts) #30567 * http2: - implement capture rection for 'request' and 'stream' events (Matteo Collina) #27867 * net: - implement capture rejections for 'connection' event (Matteo Collina) #27867 * repl: - support previews by eager evaluating input (Ruben Bridgewater) #30811 * stream: - add support for captureRejection option (Matteo Collina) #27867 * tls: - implement capture rejections for 'secureConnection' event (Matteo Collina) #27867 - expose IETF name for current cipher suite (Sam Roberts) #30637 * worker: - add argv constructor option (legendecas) #30559 PR-URL: #30937

@targos PTAL I've fixed commit + changelog

This is a security release. This release includes a single commit, an update to npm to 6.13.4. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: * update npm to 6.13.4 #30904 * update uvwasi (Anna Henningsen) #30745 * upgrade to libuv 1.34.0 (Colin Ihrig) #30783 * doc: * docs deprecate http finished (Robert Nagy) #28679 * events: * add captureRejection option (Matteo Collina) #27867 * http: * add captureRejection support (Matteo Collina) #27867 * llhttp opt-in insecure HTTP header parsing (Sam Roberts) #30567 * http2: * implement capture rection for 'request' and 'stream' events (Matteo Collina) #27867 * net: * implement capture rejections for 'connection' event (Matteo Collina) #27867 * repl: * support previews by eager evaluating input (Ruben Bridgewater) #30811 * stream: * add support for captureRejection option (Matteo Collina) #27867 * tls: * implement capture rejections for 'secureConnection' event (Matteo Collina) #27867 * expose IETF name for current cipher suite (Sam Roberts) #30637 * worker: * add argv constructor option (legendecas) #30559 PR-URL: #30937

This is a security release. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: * update npm to 6.13.4 #30904 * update uvwasi (Anna Henningsen) #30745 * upgrade to libuv 1.34.0 (Colin Ihrig) #30783 * doc: * docs deprecate http finished (Robert Nagy) #28679 * events: * add captureRejection option (Matteo Collina) #27867 * http: * add captureRejection support (Matteo Collina) #27867 * llhttp opt-in insecure HTTP header parsing (Sam Roberts) #30567 * http2: * implement capture rection for 'request' and 'stream' events (Matteo Collina) #27867 * net: * implement capture rejections for 'connection' event (Matteo Collina) #27867 * repl: * support previews by eager evaluating input (Ruben Bridgewater) #30811 * stream: * add support for captureRejection option (Matteo Collina) #27867 * tls: * implement capture rejections for 'secureConnection' event (Matteo Collina) #27867 * expose IETF name for current cipher suite (Sam Roberts) #30637 * worker: * add argv constructor option (legendecas) #30559 PR-URL: #30937

LGTM

CI: https://ci.nodejs.org/job/node-test-pull-request/27747/
CITGM: https://ci.nodejs.org/job/citgm-smoker/2124/

CI: https://ci.nodejs.org/job/node-test-pull-request/27756/
rerun plinux: https://ci.nodejs.org/job/node-test-commit-plinux/29782/
CITGM: https://ci.nodejs.org/job/citgm-smoker/2136/
Rerun arm: https://ci.nodejs.org/job/node-test-commit-arm/28264/
rerun debian-9 armv7: https://ci.nodejs.org/job/node-test-commit-arm/28266/

PR-URL: #30937

This is a security release. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: * update npm to 6.13.4 #30904 * update uvwasi (Anna Henningsen) #30745 * upgrade to libuv 1.34.0 (Colin Ihrig) #30783 * doc: * docs deprecate http finished (Robert Nagy) #28679 * events: * add captureRejection option (Matteo Collina) #27867 * http: * add captureRejection support (Matteo Collina) #27867 * llhttp opt-in insecure HTTP header parsing (Sam Roberts) #30567 * http2: * implement capture rection for 'request' and 'stream' events (Matteo Collina) #27867 * net: * implement capture rejections for 'connection' event (Matteo Collina) #27867 * repl: * support previews by eager evaluating input (Ruben Bridgewater) #30811 * stream: * add support for captureRejection option (Matteo Collina) #27867 * tls: * implement capture rejections for 'secureConnection' event (Matteo Collina) #27867 * expose IETF name for current cipher suite (Sam Roberts) #30637 * worker: * add argv constructor option (legendecas) #30559 PR-URL: #30937

Refs: nodejs/node#30937 Refs: nodejs/node#30938 Refs: nodejs/node#30940 Refs: nodejs/node#30941

mcollina and others added 30 commits December 9, 2019 10:22

src: fix node_dir.cc memory allocation

b51b26f

PR-URL: #30750 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

src: remove redundant cast in node_dir.cc

66db874

PR-URL: #30747 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

src: delete redundant method in node_dir.h

838ae10

PR-URL: #30747 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

doc: clarify text about using 'session' event for compatibility

8369562

PR-URL: #30746 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

worker: add argv constructor option

71d43a5

A convenience option to populate `process.argv` in worker threads. PR-URL: #30559 Fixes: #30531 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

fs: fix existsSync for invalid symlink at win32

60b1e1a

Fixes: #30538 PR-URL: #30556 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

doc: fix up N-API doc

543bf9d

PR-URL: #30656 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

test: increase debugging information in subprocess test

54a266c

Refs: #25988 (comment) PR-URL: #30761 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

tools: update ESLint to 6.7.2

7b9400c

PR-URL: #30762 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

module: add warnings for experimental flags

851f313

PR-URL: #30617 Fixes: #30600 Reviewed-By: Guy Bedford <guybedford@gmail.com>

codebytere approved these changes Dec 13, 2019

View reviewed changes

targos suggested changes Dec 13, 2019

View reviewed changes

cjihrig approved these changes Dec 13, 2019

View reviewed changes

This was referenced Dec 16, 2019

v8.17.0 proposal #30941

Merged

v10.18.0 proposal #30940

Merged

v12.14.0 proposal #30938

Merged

MylesBorins force-pushed the v13.4.0-proposal branch from d6fcb10 to 57bf5b7 Compare December 16, 2019 16:43

This comment has been minimized.

Sign in to view

MylesBorins force-pushed the v13.4.0-proposal branch from 57bf5b7 to 906a1fd Compare December 16, 2019 16:56

This comment has been minimized.

Sign in to view

richardlau reviewed Dec 16, 2019

View reviewed changes

Comment thread doc/changelogs/CHANGELOG_V13.md

MylesBorins force-pushed the v13.4.0-proposal branch from 906a1fd to f15fe94 Compare December 16, 2019 19:57

This comment has been minimized.

Sign in to view

richardlau approved these changes Dec 16, 2019

View reviewed changes

MylesBorins merged commit f15fe94 into v13.x Dec 17, 2019

MylesBorins added a commit that referenced this pull request Dec 17, 2019

Working on v13.4.1

96a65e8

PR-URL: #30937

MylesBorins mentioned this pull request Dec 17, 2019

blog: December sec releases nodejs/nodejs.org#2837

Merged

MylesBorins added a commit to nodejs/nodejs.org that referenced this pull request Dec 17, 2019

blog: December sec releases

089341b

Refs: nodejs/node#30937 Refs: nodejs/node#30938 Refs: nodejs/node#30940 Refs: nodejs/node#30941

ljharb mentioned this pull request Dec 17, 2019

wasi: require CLI flag to require() wasi module #30963

Closed

3 tasks

addaleax deleted the v13.4.0-proposal branch January 7, 2020 15:46

v13.4.0 proposal by MylesBorins · Pull Request #30937 · nodejs/node · GitHub

Uh oh!

Uh oh!

v13.4.0 proposal - #30937

v13.4.0 proposal#30937
MylesBorins merged 117 commits into
v13.xfrom
v13.4.0-proposal

MylesBorins commented Dec 13, 2019

Uh oh!

targos left a comment

Uh oh!

joaocgreis commented Dec 13, 2019

Uh oh!

This comment has been minimized.

MylesBorins commented Dec 16, 2019

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

targos commented Dec 16, 2019

Uh oh!

nodejs-github-bot commented Dec 16, 2019 •
edited by MylesBorins
Loading

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 17, 2019 •
edited by MylesBorins
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

v13.4.0 proposal by MylesBorins · Pull Request #30937 · nodejs/node · GitHub

Uh oh!

Uh oh!

v13.4.0 proposal - #30937

v13.4.0 proposal#30937MylesBorins merged 117 commits intov13.xnodejs/node:v13.xfrom v13.4.0-proposalnodejs/node:v13.4.0-proposalCopy head branch name to clipboard

Conversation

MylesBorins commented Dec 13, 2019

2019-12-17, Version 13.4.0 (Current), @MylesBorins

Notable Changes

Commits

Uh oh!

targos left a comment

Choose a reason for hiding this comment

Uh oh!

joaocgreis commented Dec 13, 2019

Uh oh!

This comment has been minimized.

MylesBorins commented Dec 16, 2019

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

targos commented Dec 16, 2019

Uh oh!

nodejs-github-bot commented Dec 16, 2019 • edited by MylesBorins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 17, 2019 • edited by MylesBorins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

v13.4.0 proposal#30937
MylesBorins merged 117 commits into
v13.xfrom
v13.4.0-proposal

nodejs-github-bot commented Dec 16, 2019 •
edited by MylesBorins
Loading

nodejs-github-bot commented Dec 17, 2019 •
edited by MylesBorins
Loading