node_crypto: Don't use deprecated OpenSSL APIs - #30812
Closed
neheb wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sam-github
approved these changes
Dec 5, 2019
jasnell
approved these changes
Dec 5, 2019
Copy link
Copy Markdown
Contributor
Author
|
No idea what the failures are about. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Click through the details: https://travis-ci.com/nodejs/node/jobs/263603120 |
Sorry, something went wrong.
The extra headers are needed when deprecated APIs are disabled as ssl.h no longer includes them implicitly.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
No idea what the issue is this time. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Dec 6, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
devnexen
approved these changes
Dec 6, 2019
cjihrig
approved these changes
Dec 6, 2019
Copy link
Copy Markdown
Contributor
Author
|
Not related? 14:32:07 not ok 1576 parallel/test-readline-async-iterators-destroy
14:32:07 ---
14:32:07 duration_ms: 2.143
14:32:07 severity: fail
14:32:07 exitcode: 1
14:32:07 stack: |-
14:32:07 events.js:279
14:32:07 throw er; // Unhandled 'error' event
14:32:07 ^
14:32:07
14:32:07 Error: EBADF: bad file descriptor, read
14:32:07 Emitted 'error' event on ReadStream instance at:
14:32:07 at internal/fs/streams.js:186:12
14:32:07 at FSReqCallback.wrapper [as oncomplete] (fs.js:490:5) {
14:32:07 errno: -9,
14:32:07 code: 'EBADF',
14:32:07 syscall: 'read'
14:32:07 }
14:51:22 not ok 2661 sequential/test-heap-prof
14:51:22 ---
14:51:22 duration_ms: 120.871
14:51:22 severity: fail
14:51:22 exitcode: -15
14:51:22 stack: |-
14:51:22 timeout
14:51:22 ...
|
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Dec 7, 2019
The extra headers are needed when deprecated APIs are disabled as ssl.h no longer includes them implicitly. PR-URL: #30812 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
The extra headers are needed when deprecated APIs are disabled as ssl.h no longer includes them implicitly. PR-URL: #30812 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
The extra headers are needed when deprecated APIs are disabled as ssl.h no longer includes them implicitly. PR-URL: #30812 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
The extra headers are needed when deprecated APIs are disabled as ssl.h no longer includes them implicitly. PR-URL: #30812 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra headers are needed when deprecated APIs are disabled as ssl.h
no longer includes them implicitly.