FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: free preopen memory in WASI::New() by cjihrig · Pull Request #30809 · nodejs/node · GitHub

/ node Public

src: free preopen memory in WASI::New() - #30809

Closed
cjihrig wants to merge 2 commits into
nodejs:masterfrom
cjihrig:wasi-mem
ConversationCommits (2)ChecksFiles changed
Closed

src: free preopen memory in WASI::New()#30809
cjihrig wants to merge 2 commits into
nodejs:masterfrom
cjihrig:wasi-mem

Conversation

cjihrig commented Dec 5, 2019

Copy link
Copy Markdown
Contributor

Refs: #30257

cc: @gengjiawen

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 5, 2019

nodejs-github-bot commented Dec 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27382/

nodejs-github-bot commented Dec 6, 2019 •
edited by cjihrig
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27422/ 💛

cjihrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 7, 2019
Trott pushed a commit that referenced this pull request Dec 7, 2019
src: use checked allocations in WASI::New()
0fe54f2 
PR-URL: #30809
Refs: #30257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Trott pushed a commit that referenced this pull request Dec 7, 2019
src: free preopen memory in WASI::New()
46aa7d0 
PR-URL: #30809
Refs: #30257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>

Trott commented Dec 7, 2019

Copy link
Copy Markdown
Member

Landed in 147317f...46aa7d0

Trott closed this Dec 7, 2019
cjihrig deleted the wasi-mem branch December 7, 2019 23:22
targos pushed a commit that referenced this pull request Dec 9, 2019
src: use checked allocations in WASI::New()
e6e379e 
PR-URL: #30809
Refs: #30257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos pushed a commit that referenced this pull request Dec 9, 2019
src: free preopen memory in WASI::New()
8ad53ab 
PR-URL: #30809
Refs: #30257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
src: use checked allocations in WASI::New()
808a456 
PR-URL: #30809
Refs: #30257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos pushed a commit that referenced this pull request Jan 14, 2020
src: free preopen memory in WASI::New()
1148724 
PR-URL: #30809
Refs: #30257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
src: use checked allocations in WASI::New()
e9bda66 
PR-URL: #30809
Refs: #30257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
src: free preopen memory in WASI::New()
bf78914 
PR-URL: #30809
Refs: #30257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
addaleax addaleax approved these changes
gengjiawen gengjiawen approved these changes
+1 more reviewer
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL