FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update ESLint to 6.7.2 by Trott · Pull Request #30762 · nodejs/node · GitHub

/ node Public

tools: update ESLint to 6.7.2 - #30762

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:eslint-6.7.2
Dec 4, 2019
ConversationCommits (1)ChecksFiles changed
Merged

tools: update ESLint to 6.7.2#30762
Trott merged 1 commit into
nodejs:masterfrom
Trott:eslint-6.7.2

Conversation

Trott commented Dec 2, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 2, 2019

Trott commented Dec 2, 2019

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4095/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 2, 2019
trivikr approved these changes Dec 3, 2019
View reviewed changes

trivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

tools: update ESLint to 6.7.2
12254ce 
PR-URL: nodejs#30762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Trott commented Dec 4, 2019

Copy link
Copy Markdown
Member Author

Landed in 12254ce

Trott merged commit 12254ce into nodejs:master Dec 4, 2019
Trott deleted the eslint-6.7.2 branch December 4, 2019 13:39
targos pushed a commit that referenced this pull request Dec 9, 2019
tools: update ESLint to 6.7.2
7b9400c 
PR-URL: #30762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
tools: update ESLint to 6.7.2
54140a8 
PR-URL: #30762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
tools: update ESLint to 6.7.2
fcecd09 
PR-URL: #30762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL