FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: use CC instead of CXX when pointing to gcc by miladfarca · Pull Request #30817 · nodejs/node · GitHub

/ node Public

tools: use CC instead of CXX when pointing to gcc - #30817

Closed
miladfarca wants to merge 2 commits into
nodejs:masterfrom
miladfarca:cc-fix
ConversationCommits (2)ChecksFiles changed
Closed

tools: use CC instead of CXX when pointing to gcc#30817
miladfarca wants to merge 2 commits into
nodejs:masterfrom
miladfarca:cc-fix

Conversation

miladfarca commented Dec 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Currently gcc is pointing to CXX (g++) instead of the actual gcc which is causing failures when compiling V8

tools: use CC instead of CXX when pointing to gcc
2e61c63 
Current CC flag points to g++ instead of gcc which is causing failures when compiling V8
nodejs-github-bot added tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Dec 6, 2019
gireeshpunathil reviewed Dec 6, 2019
View reviewed changes
Comment thread tools/make-v8.sh
miladfarca mentioned this pull request Dec 6, 2019
Closed

nodejs-github-bot commented Dec 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27388/

gireeshpunathil commented Dec 6, 2019

Copy link
Copy Markdown
Member

call for fast-track, helps resolving broken build. please 👍 if you are with me.

nodejs-github-bot commented Dec 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27393/

gireeshpunathil commented Dec 6, 2019

Copy link
Copy Markdown
Member

I see this in the CI: Jenkins is going to shut down - any idea? is part of a planned outage? @nodejs/build

rvagg commented Dec 6, 2019

Copy link
Copy Markdown
Member

unplanned, need to update and restart jenkins, waiting for current jobs to flush out and it'll be back up again and ready

nodejs-github-bot commented Dec 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27398/

targos commented Dec 6, 2019

Copy link
Copy Markdown
Member

Only V8 CI uses this script: https://ci.nodejs.org/job/node-test-commit-v8-linux/2684/

gireeshpunathil commented Dec 6, 2019

Copy link
Copy Markdown
Member

Only V8 CI uses this script

@targos - does this mean the regular CI builds libv8* differently?

targos commented Dec 6, 2019

Copy link
Copy Markdown
Member

@gireeshpunathil regular CI builds V8 along with node (./configure, gyp, make)

mhdawson approved these changes Dec 6, 2019
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nodejs-github-bot commented Dec 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27404/

nodejs-github-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27430/

nodejs-github-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27431/

nodejs-github-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27438/

nodejs-github-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27441/

nodejs-github-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27442/

richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 7, 2019
richardlau pushed a commit that referenced this pull request Dec 7, 2019
tools: use CC instead of CXX when pointing to gcc
cf5ce2c 
Current CC flag points to g++ instead of gcc which is causing failures
when compiling V8.

PR-URL: #30817
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

richardlau commented Dec 7, 2019

Copy link
Copy Markdown
Member

Fixed up the commit message and landed in cf5ce2c.

richardlau closed this Dec 7, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
tools: use CC instead of CXX when pointing to gcc
1ed1a64 
Current CC flag points to g++ instead of gcc which is causing failures
when compiling V8.

PR-URL: #30817
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
tools: use CC instead of CXX when pointing to gcc
7558d8b 
Current CC flag points to g++ instead of gcc which is causing failures
when compiling V8.

PR-URL: #30817
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
tools: use CC instead of CXX when pointing to gcc
21ccbdd 
Current CC flag points to g++ instead of gcc which is causing failures
when compiling V8.

PR-URL: #30817
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Mar 2, 2020
tools: use CC instead of CXX when pointing to gcc
61e2d48 
Current CC flag points to g++ instead of gcc which is causing failures
when compiling V8.

PR-URL: #30817
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs mentioned this pull request Mar 12, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
gireeshpunathil gireeshpunathil approved these changes
+3 more reviewers
targos targos approved these changes
devnexen devnexen approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL