doc: clarify Tier 2 implications in BUILDING.md - #30866
Merged
Trott merged 1 commit intoDec 11, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
bnoordhuis
approved these changes
Dec 9, 2019
targos
approved these changes
Dec 9, 2019
BethGriggs
approved these changes
Dec 9, 2019
cjihrig
approved these changes
Dec 9, 2019
gireeshpunathil
approved these changes
Dec 9, 2019
richardlau
approved these changes
Dec 9, 2019
lpinca
approved these changes
Dec 9, 2019
trivikr
approved these changes
Dec 9, 2019
mhdawson
approved these changes
Dec 9, 2019
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
rvagg
approved these changes
Dec 10, 2019
rvagg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I have to squint to see the difference. I think you're just removing the passive, us-focused voice and making it active, user-focused, right?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Yes. Subjectively, I find "are acceptable where necessary due to infrastructure concerns" makes me wonder if I didn't understand it correctly. So replacing that with a more direct active voice seems easier-to-understand, at least to me. |
Sorry, something went wrong.
Clarify the explanation of Tier 2 platforms and binary releases. PR-URL: nodejs#30866 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 13, 2019
Clarify the explanation of Tier 2 platforms and binary releases. PR-URL: #30866 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Clarify the explanation of Tier 2 platforms and binary releases. PR-URL: #30866 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Clarify the explanation of Tier 2 platforms and binary releases. PR-URL: #30866 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify the explanation of Tier 2 platforms and binary releases.
@nodejs/build especially @rvagg
Checklist