FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: add parent to ERR_UNKNOWN_FILE_EXTENSION message by qualitymanifest · Pull Request #30728 · nodejs/node · GitHub

/ node Public

lib: add parent to ERR_UNKNOWN_FILE_EXTENSION message - #30728

Closed
qualitymanifest wants to merge 4 commits into
nodejs:masterfrom
qualitymanifest:add-parent-err-unknown-file-ext
ConversationCommits (4)ChecksFiles changed
Closed

lib: add parent to ERR_UNKNOWN_FILE_EXTENSION message#30728
qualitymanifest wants to merge 4 commits into
nodejs:masterfrom
qualitymanifest:add-parent-err-unknown-file-ext

Conversation

qualitymanifest commented Nov 30, 2019

Copy link
Copy Markdown
Contributor
  • default_resolve.js updated to pass parentURL into error
  • ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
  • test added to check for import message in error

Fixes: #30721

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Nov 30, 2019
guybedford reviewed Nov 30, 2019
View reviewed changes
Comment thread lib/internal/errors.js Outdated
guybedford approved these changes Nov 30, 2019
View reviewed changes

guybedford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for taking this one on, looks great.

guybedford reviewed Nov 30, 2019
View reviewed changes
Comment thread lib/internal/errors.js Outdated
guybedford added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 2, 2019
BridgeAR approved these changes Dec 2, 2019
View reviewed changes
Comment thread lib/internal/errors.js Outdated

nodejs-github-bot commented Dec 3, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27293/

nodejs-github-bot commented Dec 3, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27315/

addaleax added the esm Issues and PRs related to the ECMAScript Modules implementation. label Dec 3, 2019

joaocgreis commented Dec 4, 2019

Copy link
Copy Markdown
Member

Windows CI rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/31957/

nodejs-github-bot commented Dec 5, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27335/

nodejs-github-bot commented Dec 5, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27338/

lib: add parent to ERR_UNKNOWN_FILE_EXTENSION message
dba463e 
- default_resolve updated to pass parentURL into error
- ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
- test added to check for import message in error

Fixes: #30721
lib: add explicit ext to ERR_UNKNOWN_FILE_EXTENSION
c1c93bc
lib: quote ext in ERR_UNKNOWN_FILE_EXTENSION
dce3560
lib: remove quote escaping for ERR_UNKNOWN_FILE_EXTENSION
8fd0143

nodejs-github-bot commented Dec 5, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27339/

joaocgreis commented Dec 5, 2019

Copy link
Copy Markdown
Member

Windows CI rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/32003/

nodejs-github-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27433/

nodejs-github-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27439/

nodejs-github-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27443/

guybedford pushed a commit that referenced this pull request Dec 7, 2019
lib: add parent to ERR_UNKNOWN_FILE_EXTENSION
7ab21b2 
- default_resolve updated to pass parentURL into error
- ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
- test added to check for import message in error

PR-URL: #30728
Fixes: #30721
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

guybedford commented Dec 7, 2019

Copy link
Copy Markdown
Contributor

Landed in 7ab21b2.

guybedford closed this Dec 7, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
lib: add parent to ERR_UNKNOWN_FILE_EXTENSION
2c439bb 
- default_resolve updated to pass parentURL into error
- ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
- test added to check for import message in error

PR-URL: #30728
Fixes: #30721
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Dec 13, 2019
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
lib: add parent to ERR_UNKNOWN_FILE_EXTENSION
15d48f9 
- default_resolve updated to pass parentURL into error
- ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
- test added to check for import message in error

PR-URL: #30728
Fixes: #30721
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
lib: add parent to ERR_UNKNOWN_FILE_EXTENSION
1698a53 
- default_resolve updated to pass parentURL into error
- ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
- test added to check for import message in error

PR-URL: #30728
Fixes: #30721
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

guybedford guybedford approved these changes
BridgeAR BridgeAR approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. esm Issues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

esm: invalid extension error should provide parent context in error

9 participants

Back | FazBrowse Home | New Git URL