FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: add warning on dynamic import es modules by juanarbol · Pull Request #30720 · nodejs/node · GitHub

/ node Public

lib: add warning on dynamic import es modules - #30720

Closed
juanarbol wants to merge 3 commits into
nodejs:masterfrom
juanarbol:warning-es-dynamic-import
ConversationCommits (3)ChecksFiles changed
Closed

lib: add warning on dynamic import es modules#30720
juanarbol wants to merge 3 commits into
nodejs:masterfrom
juanarbol:warning-es-dynamic-import

Conversation

juanarbol commented Nov 29, 2019 •
edited by guybedford
Loading

Copy link
Copy Markdown
Member

Fixes #30601.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Nov 29, 2019

juanarbol commented Nov 29, 2019

Copy link
Copy Markdown
Member Author

Ref: #30601

cjihrig commented Nov 30, 2019

Copy link
Copy Markdown
Contributor

Can you add a test please.

juanarbol commented Nov 30, 2019

Copy link
Copy Markdown
Member Author

Sure, should I use a child process and test std err, or is there another way?

cjihrig commented Nov 30, 2019

Copy link
Copy Markdown
Contributor

We have common.expectWarning() in our tests. You should be able to look in the test/ directory for examples.

juanarbol commented Dec 1, 2019

Copy link
Copy Markdown
Member Author

As long as code is undefined, common.expectWarning throws me an exception. So I used assertions instead of expectWarning

const [ message, code ] = expected.shift();
                              ^

TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))

guybedford requested changes Dec 2, 2019
View reviewed changes
Comment thread lib/internal/process/esm_loader.js Outdated

juanarbol commented Dec 2, 2019

Copy link
Copy Markdown
Member Author

@guybedford Done! Thanks for reviewing! Tell me if something else is not correct.

guybedford added the esm Issues and PRs related to the ECMAScript Modules implementation. label Dec 7, 2019
guybedford approved these changes Dec 7, 2019
View reviewed changes

guybedford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good to me.

nodejs-github-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27432/

guybedford added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 7, 2019
guybedford pushed a commit that referenced this pull request Dec 7, 2019
lib: add warning on dynamic import es modules
6669cd1 
PR-URL: #30720
Reviewed-By: Guy Bedford <guybedford@gmail.com>

guybedford commented Dec 7, 2019

Copy link
Copy Markdown
Contributor

Landed in 6669cd1.

guybedford closed this Dec 7, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
lib: add warning on dynamic import es modules
d9d6475 
PR-URL: #30720
Reviewed-By: Guy Bedford <guybedford@gmail.com>
coreyfarrell mentioned this pull request Dec 12, 2019
Closed
MylesBorins mentioned this pull request Dec 13, 2019
Merged

targos commented Jan 14, 2020

Copy link
Copy Markdown
Member

Depends on #29866 to land on v12.x-staging

coreyfarrell mentioned this pull request Jan 23, 2020
Closed
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
lib: add warning on dynamic import es modules
ab9eedf 
PR-URL: nodejs#30720
Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos pushed a commit to targos/node that referenced this pull request May 7, 2020
lib: add warning on dynamic import es modules
c16d4da 
PR-URL: nodejs#30720
Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos added backported-to-v12.x and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. backport-open-v12.x labels May 7, 2020
targos pushed a commit that referenced this pull request May 7, 2020
lib: add warning on dynamic import es modules
233b988 
PR-URL: #30720
Backport-PR-URL: #33055
Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
lib: add warning on dynamic import es modules
698e21b 
PR-URL: #30720
Backport-PR-URL: #33055
Reviewed-By: Guy Bedford <guybedford@gmail.com>
juanarbol deleted the warning-es-dynamic-import branch January 19, 2021 16:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

guybedford guybedford approved these changes

Assignees

No one assigned

Labels

esm Issues and PRs related to the ECMAScript Modules implementation. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Experimental modules warning does not show when using dynamic import

5 participants

Back | FazBrowse Home | New Git URL