FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark addons/openssl-bindings/test flaky on arm by richardlau · Pull Request #30838 · nodejs/node · GitHub

/ node Public

test: mark addons/openssl-bindings/test flaky on arm - #30838

Closed
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:flaky
ConversationCommits (1)ChecksFiles changed
Closed

test: mark addons/openssl-bindings/test flaky on arm#30838
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:flaky

Conversation

richardlau commented Dec 7, 2019

Copy link
Copy Markdown
Member

Refs: #30786

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Dec 7, 2019
richardlau added arm Issues and PRs related to the ARM architecture. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Dec 7, 2019

nodejs-github-bot commented Dec 7, 2019 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27457/

(From the above run here is the test failing and being marked flaky: https://ci.nodejs.org/job/node-test-binary-arm-12+/3034/RUN_SUBSET=addons,label=pi2-docker/)

richardlau mentioned this pull request Dec 7, 2019
Closed
richardlau added the openssl Issues and PRs related to the OpenSSL dependency. label Dec 7, 2019

cjihrig commented Dec 7, 2019

Copy link
Copy Markdown
Contributor

Should we fast track this? I think so. 👍 here if you agree.

nodejs-github-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27462/

nodejs-github-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27463/

nodejs-github-bot commented Dec 7, 2019 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27464/ (⚠️)

richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 7, 2019
richardlau added a commit that referenced this pull request Dec 7, 2019
test: mark addons/openssl-bindings/test flaky on arm
d4e00ec 
PR-URL: #30838
Refs: #30786
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

richardlau commented Dec 7, 2019

Copy link
Copy Markdown
Member Author

Landed in d4e00ec.

richardlau closed this Dec 7, 2019
richardlau deleted the flaky branch December 7, 2019 21:09
targos pushed a commit that referenced this pull request Dec 9, 2019
test: mark addons/openssl-bindings/test flaky on arm
4dc9d8d 
PR-URL: #30838
Refs: #30786
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
test: mark addons/openssl-bindings/test flaky on arm
39d770c 
PR-URL: #30838
Refs: #30786
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
test: mark addons/openssl-bindings/test flaky on arm
fe3818e 
PR-URL: #30838
Refs: #30786
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
ZYSzys ZYSzys approved these changes

Assignees

No one assigned

Labels

addons Issues and PRs related to native addons. arm Issues and PRs related to the ARM architecture. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. openssl Issues and PRs related to the OpenSSL dependency. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL