FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

inspector: do not access queueMicrotask from global by targos · Pull Request #30732 · nodejs/node · GitHub

/ node Public

inspector: do not access queueMicrotask from global - #30732

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:safe-queue-microtask
Closed

inspector: do not access queueMicrotask from global#30732
targos wants to merge 1 commit into
nodejs:masterfrom
targos:safe-queue-microtask

Conversation

targos commented Nov 30, 2019

Copy link
Copy Markdown
Member

Grab it from the internal module where it's defined instead.

Grab it from the internal module where it's defined instead.
nodejs-github-bot added the inspector Issues and PRs related to the V8 inspector protocol label Nov 30, 2019

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

targos added a commit that referenced this pull request Dec 4, 2019
Grab it from the internal module where it's defined instead.

PR-URL: #30732
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos commented Dec 4, 2019

Copy link
Copy Markdown
Member Author

Landed in b9cacfc

targos closed this Dec 4, 2019
targos deleted the safe-queue-microtask branch December 4, 2019 07:50
targos added a commit that referenced this pull request Dec 9, 2019
Grab it from the internal module where it's defined instead.

PR-URL: #30732
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Dec 13, 2019
targos added a commit that referenced this pull request Jan 13, 2020
Grab it from the internal module where it's defined instead.

PR-URL: #30732
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
Grab it from the internal module where it's defined instead.

PR-URL: #30732
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Feb 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL