FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update status of Python 3 support by mhdawson · Pull Request #30722 · nodejs/node · GitHub

/ node Public

doc: update status of Python 3 support - #30722

Closed
mhdawson wants to merge 4 commits into
nodejs:masterfrom
mhdawson:python3-doc
ConversationCommits (4)ChecksFiles changed
Closed

doc: update status of Python 3 support#30722
mhdawson wants to merge 4 commits into
nodejs:masterfrom
mhdawson:python3-doc

Conversation

mhdawson commented Nov 29, 2019

Copy link
Copy Markdown
Member

Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

doc: update status of Python 3 support
be9c0e6 
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.
nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 29, 2019

mhdawson commented Nov 29, 2019

Copy link
Copy Markdown
Member Author

@sam-github, @cclauss this reflect my understanding, can you validate?

targos reviewed Nov 29, 2019
View reviewed changes
Comment thread BUILDING.md Outdated
sam-github reviewed Nov 29, 2019
View reviewed changes
Comment thread BUILDING.md Outdated
sam-github approved these changes Nov 29, 2019
View reviewed changes

sam-github left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A couple suggestions to simplify, but generally LGTM

mhdawson and others added 3 commits December 3, 2019 10:37
Update BUILDING.md
57d510e 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
Update BUILDING.md
cc4d4f8
squash: address comments
2d388e5

mhdawson commented Dec 3, 2019

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4098/

cclauss commented Dec 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Given that Python 2 end of life is in 29 days, I would recommend the following simplification:

The Node.js project can use either Python 2 or Python 3 in its build process. If both are installed, then Python 3 will be used. If only Python 2 is available, then it will be used instead. Whenever possible, we recommend that you build and test with Python 3.

mhdawson commented Dec 3, 2019

Copy link
Copy Markdown
Member Author

CI good, just waiting for Travis to complete.

mhdawson commented Dec 3, 2019

Copy link
Copy Markdown
Member Author

Travis is good landing.

mhdawson added a commit that referenced this pull request Dec 3, 2019
doc: update status of Python 3 support
7bee77f 
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.

PR-URL: #30722
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

mhdawson commented Dec 3, 2019

Copy link
Copy Markdown
Member Author

Landed as 7bee77f

mhdawson closed this Dec 3, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
doc: update status of Python 3 support
145f881 
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.

PR-URL: #30722
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins mentioned this pull request Dec 13, 2019
Merged
mhdawson deleted the python3-doc branch September 14, 2020 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
jasnell jasnell approved these changes
addaleax addaleax approved these changes
gengjiawen gengjiawen approved these changes
joyeecheung joyeecheung approved these changes
+2 more reviewers
targos targos left review comments
sam-github sam-github approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL