FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

buffer: use for...of by trivikr · Pull Request #30962 · nodejs/node · GitHub

/ node Public

buffer: use for...of - #30962

Closed
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:use-for-of-buffer
ConversationCommits (1)ChecksFiles changed
Closed

buffer: use for...of#30962
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:use-for-of-buffer

Conversation

trivikr commented Dec 14, 2019

Copy link
Copy Markdown
Member

Searched for regular expression for \([^\.]*.length in lib and made changes in buffer.js

Refs: #30910 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the buffer Issues and PRs related to the buffer subsystem. label Dec 14, 2019

cjihrig commented Dec 14, 2019

Copy link
Copy Markdown
Contributor

Can you consolidate these PRs? All of the separate PRs makes for a lot of noise.

trivikr commented Dec 14, 2019

Copy link
Copy Markdown
Member Author

Can you consolidate these PRs?

I've posted PRs specific to submodules - buffer, stream, http, tls

A single PR might get blocked/delayed/might not land in old versions/etc because of changes specific to any of the submodules.
For example, for...of in stream won't be landing on 10.x #30960 (review)

cjihrig commented Dec 14, 2019

Copy link
Copy Markdown
Contributor

You could use separate commits in a single PR.

nodejs-github-bot commented Dec 14, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27679/

SimonSchick commented Dec 14, 2019

Copy link
Copy Markdown
Contributor

Would be curious to know how much affects concat performance.

mcollina requested changes Dec 14, 2019
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we should keep this as-is.

trivikr closed this Dec 15, 2019
trivikr deleted the use-for-of-buffer branch December 15, 2019 20:51
trivikr mentioned this pull request Dec 24, 2019
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina requested changes

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL