FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

repl: use for...of by trivikr · Pull Request #31050 · nodejs/node · GitHub

/ node Public

repl: use for...of - #31050

Closed
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:repl-for-of
Closed

repl: use for...of#31050
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:repl-for-of

Conversation

trivikr commented Dec 21, 2019

Copy link
Copy Markdown
Member

Searched for regular expression for \([^\.]*.length in lib and made changes in repl submodule

Refs: #30910 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Dec 21, 2019

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

I think it would be better to have a single PR that include #31049 and #31051. Having lots of very tiny PRs is a lot of overhead in this case.

I am not sure we should really change these as long as we do not touch any of these files due to something else though.

trivikr commented Dec 24, 2019

Copy link
Copy Markdown
Member Author

@cjihrig had raised similar request, and this is explanation I'd given #30962 (comment)

A single PR will need lot of follow-up, when different decisions are taken for different submodules like:

Copy link
Copy Markdown
Collaborator

trivikr commented Jan 4, 2020

Copy link
Copy Markdown
Member Author

Closing as most collaborators are opposed to such changes.
Example #30958 (comment)

trivikr closed this Jan 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL