test: fix flaky test-gc-net-timeout - #31918
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
If the timeout is called in the time between 'end' and 'close' that would cause a EPIPE error. Essentially making the test flaky.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ronag
commented
Feb 22, 2020
Comment thread
test/parallel/test-gc-net-timeout.js
| sock.on('close', function() { | ||
| clearTimeout(timer); | ||
| }); | ||
| sock.on('end', function() { |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
'end' will cause the writable side to be end():d due to allowHalfOpen: false.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/29300/ (:heavy_check_mark:) |
Sorry, something went wrong.
addaleax
approved these changes
Feb 26, 2020
Copy link
Copy Markdown
Member
Author
|
The same change got an approval in another PR (#31806) so I will consider that as the second required approval. |
Sorry, something went wrong.
ronag
added a commit
that referenced
this pull request
Mar 1, 2020
If the timeout is called in the time between 'end' and 'close' that would cause a EPIPE error. Essentially making the test flaky. PR-URL: #31918 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 3, 2020
If the timeout is called in the time between 'end' and 'close' that would cause a EPIPE error. Essentially making the test flaky. PR-URL: #31918 Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
If the timeout is called in the time between 'end' and 'close' that would cause a EPIPE error. Essentially making the test flaky. PR-URL: #31918 Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
If the timeout is called in the time between 'end' and 'close' that would cause a EPIPE error. Essentially making the test flaky. PR-URL: #31918 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
If the timeout is called in the time between 'end' and 'close' that would cause a EPIPE error. Essentially making the test flaky. PR-URL: #31918 Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the timeout is called in the time between 'end' and 'close' that would cause a EPIPE error. Essentially making the test flaky.
Checklist