test: run test-abort-aliased-buffer-overflow - #32626
Conversation
Sorry, something went wrong.
Sorry, something went wrong.
|
Looks like the test is failing on Windows. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Updated to fix the Windows build. The workers CI is also failing, but I'll need to think for a bit (when it's not 3am in the morning) how to fix that because I can't just add make build-abort-tests to the job config because that target doesn't exist in any of the release lines so would break the job if run on those. |
Sorry, something went wrong.
nodejs#31740 added an addon-style test to `test/abort` that was never run because `test/abort/testcfg.py` uses the AbortTestConfiguration which inherits from SimpleTestConfiguration which only finds tests in the root of `test/abort`. Make AbortTestConfiguration inherit from AddonTestConfiguration and change AddonTestConfiguration to find the tests in the root of the test bucket in addition to the subfolders. Fixup `test-abort-aliased-buffer-overflow` so that it works as intended. Signed-off-by: Richard Lau <riclau@uk.ibm.com>
Sorry, something went wrong.
|
Fixed most of the broken CI by removing the abort tests from default since they now require compilation Lines 1487 to 1489 in b9da063 Compilation of the test is failing on Windows, e.g. https://ci.nodejs.org/job/node-test-binary-windows-native-suites/2398/nodes=win10-vs2019-COMPILED_BY-vs2019/console 03:51:56 stdout: 'Building the projects in this solution one at a time. To enable parallel build, please add the "-m" switch.\r\n' + 03:51:56 ' binding.cc\r\n' + 03:51:56 ' win_delay_load_hook.cc\r\n' + 03:51:56 ' Creating library C:\\workspace\\node-test-binary-windows-native-suites\\node\\test\\abort\\test_abort-aliased-buffer-overflow\\build\\Release\\binding.lib and object C:\\workspace\\node-test-binary-windows-native-suites\\node\\test\\abort\\test_abort-aliased-buffer-overflow\\build\\Release\\binding.exp\r\n' + 03:51:56 'binding.obj : error LNK2019: unresolved external symbol "void __cdecl node::Assert(struct node::AssertionInfo const &)" (?Assert@node@@YAXAEBUAssertionInfo@1@@Z) referenced in function "void __cdecl AllocateAndResizeBuffer(class v8::FunctionCallbackInfo<class v8::Value> const &)" (?AllocateAndResizeBuffer@@YAXAEBV?$FunctionCallbackInfo@VValue@v8@@@v8@@@Z) [C:\\workspace\\node-test-binary-windows-native-suites\\node\\test\\abort\\test_abort-aliased-buffer-overflow\\build\\binding.vcxproj]\r\n' + 03:51:56 'C:\\workspace\\node-test-binary-windows-native-suites\\node\\test\\abort\\test_abort-aliased-buffer-overflow\\build\\Release\\binding.node : fatal error LNK1120: 1 unresolved externals [C:\\workspace\\node-test-binary-windows-native-suites\\node\\test\\abort\\test_abort-aliased-buffer-overflow\\build\\binding.vcxproj]\r\n', Is the Aliased*Buffer API external (in which case this looks like a bug)? If it's internal then this really shouldn't be tested as an addon (particularly with all the build file and test configuration changes it dragged in with it) and if we really want a test for it maybe as a cctest? (Although I don't know how cctest would handle testing that something aborts.) |
Sorry, something went wrong.
|
I'm going to close this in favour of reverting the test (just the test+Makefile changes): #33196 It doesn't seem that AliasedBuffers should be tested as an addon, and mixing addons |
Sorry, something went wrong.
#31740 added an addon-style test to
test/abort that was never run because test/abort/testcfg.py uses the
AbortTestConfiguration which inherits from SimpleTestConfiguration which
only finds tests in the root of test/abort.
Make AbortTestConfiguration inherit from AddonTestConfiguration and
change AddonTestConfiguration to find the tests in the root of the test
bucket in addition to the subfolders.
Fixup test-abort-aliased-buffer-overflow so that it works as intended.
Refs: #31740
Checklist