Revert test-abort-aliased-buffer-overflow - #33196
Merged
richardlau merged 2 commits intoMay 6, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
3 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
May 1, 2020
Copy link
Copy Markdown
Member
Author
|
Technically #32624 could be reverted as well but I'm inclined to keep it to prevent any inadvertent file adds from contributors switching between branches. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #33196 +/- ##
=======================================
Coverage 96.73% 96.73%
=======================================
Files 199 199
Lines 66133 66133
=======================================
Hits 63974 63974
Misses 2159 2159 Continue to review full report at Codecov.
|
Sorry, something went wrong.
addaleax
approved these changes
May 2, 2020
BridgeAR
approved these changes
May 3, 2020
This reverts commit babeb58. PR-URL: nodejs#33196 Refs: nodejs#31740 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This reverts commit e08ac09. PR-URL: nodejs#33196 Refs: nodejs#31740 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
richardlau
force-pushed
the
revertabortaliasedbufferstest
branch
from
9769f84 to
120d707
Compare
May 6, 2020 13:41
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the test and associated Makefile changes from #31740.
This test is dead code as it is not executed as the abort tests'
AbortTestConfiguration inherits from SimpleTestConfiguration
which does not run tests in subdirectories.
node/test/abort/testcfg.py
Line 6 in e951825
node/test/testpy/__init__.py
Line 159 in e951825
AliasedBuffers do not appear to be intended for direct use by
addons so they should not be tested as such anyway. If a test
is required for #31740 one should be added as part of the
cctest, e.g. as part of test/cctest/test_aliased_buffer.cc.
Refs: #31740
Checklist