FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

2015-10-13, Version 4.2.1 'Argon' (LTS) Release by jasnell · Pull Request #3337 · nodejs/node · GitHub

/ node Public

2015-10-13, Version 4.2.1 'Argon' (LTS) Release - #3337

Closed
jasnell wants to merge 1 commit into
v4.xfrom
v4.2.1-proposal
ConversationCommits (1)ChecksFiles changed
Closed

2015-10-13, Version 4.2.1 'Argon' (LTS) Release#3337
jasnell wants to merge 1 commit into
v4.xfrom
v4.2.1-proposal

Conversation

jasnell commented Oct 13, 2015

Copy link
Copy Markdown
Member

Aiming for a quick release on Tuesday. We have two significant regressions with v4.2.0. Fixes have landed in master and v4.x. These are significant issues that affect native modules and anything using timers.

  • [b3cbd13340] - buffer: fix assertion error in WeakCallback (Fedor Indutny) #3329
  • [c245a199a7] - lib: fix undefined timeout regression (Ryan Graham) #3331

@nodejs/lts @rvagg @Fishrock123

dougwilson mentioned this pull request Oct 13, 2015
Closed
egg- added a commit to egg-/node-mysql that referenced this pull request Oct 13, 2015
temporarily until fixed. mysqljs#1236 nodejs/node#3337
eb8d0c0
mikemorris mentioned this pull request Oct 13, 2015
Closed

jasnell commented Oct 13, 2015

Copy link
Copy Markdown
Member Author

@indutny

indutny commented Oct 13, 2015

Copy link
Copy Markdown
Member

Let's land #3342 as well.

trevnorris commented Oct 13, 2015

Copy link
Copy Markdown
Contributor

@indutny I'll give 3342 a review, but doubt I'll finish before 4.2.1 needs to be released. Are those bugs critical issues, or could they wait for a week?

jasnell commented Oct 13, 2015

Copy link
Copy Markdown
Member Author

Ok, there are still issues with #3342 that need working out so we won't land that now. Let's document the issue in Known Issues and fix in the next patch release.

indutny commented Oct 13, 2015

Copy link
Copy Markdown
Member

Let's report #3342 as a known issue:

Large amount of pipelined HTTP requests may cause the underlying socket to be destroyed.

2015-10-13, Version 4.2.1 'Argon' (LTS) Release
659291c 
* Includes fixes for two regressions
  - Assertion error in WeakCallback  - see [#3329](#3329)
  - Undefined timeout regression - see [#3331](#3331)

* Document an additional known issue with pipelined requests
  - See: #3332 and #3342

jasnell commented Oct 13, 2015

Copy link
Copy Markdown
Member Author

@rvagg @indutny @Fishrock123 @trevnorris ... updated to reflect status of #3342 as a known issue. Please review.

indutny commented Oct 13, 2015

Copy link
Copy Markdown
Member

LGTM

Fishrock123 commented Oct 13, 2015

Copy link
Copy Markdown
Contributor

No strong opinion on #3342

trevnorris commented Oct 13, 2015

Copy link
Copy Markdown
Contributor

LGTM

jasnell commented Oct 13, 2015

Copy link
Copy Markdown
Member Author

Completed.

jasnell closed this Oct 13, 2015
Starefossen pushed a commit to Starefossen/docker-node that referenced this pull request Oct 13, 2015
Update to 4.2.1
04df868 
PR-URL: nodejs#56
Related: nodejs/node#3337

Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
Starefossen mentioned this pull request Oct 13, 2015
Merged
Starefossen pushed a commit to Starefossen/official-images that referenced this pull request Oct 13, 2015
Update node to v4.2.1
ac72b82 
PR-URL: docker-library#1120

Related: nodejs/docker-node#56 nodejs/node#3337

Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
Starefossen mentioned this pull request Oct 13, 2015
Merged
rvagg deleted the v4.2.1-proposal branch October 28, 2015 03:52
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
Update node to v4.2.1
f7f5d6b 
PR-URL: docker-library#1120

Related: nodejs/docker-node#56 nodejs/node#3337

Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
MayaLekova added a commit to MayaLekova/node that referenced this pull request Jul 22, 2020
process: update v8 fast api calls usage part 2
8840bbb 
Refs: nodejs#3337
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL