test: remove util from test-child-process-execsync - #3340
Closed
MylesBorins wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Now that we have backticks we no longer need to use util.format to template strings! This commit was inspired by #3324, and it replaces all instances of util.format with backtick strings to simply all the things
Copy link
Copy Markdown
Member
|
LGTM so long as CI is green |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM if CI is green. CI: https://ci.nodejs.org/job/node-test-commit/814/ Although, it looks like Jenkins is having issues right now and we might need to re-run CI later... |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
this should go to lts @jasnell |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have backticks we no longer need to use util.format to template strings! This commit was inspired by #3324, and it replaces all instances of util.format with backtick strings to simply all the things
/cc @jasnell @Trott