test: replace util with backtick strings - #3359
Conversation
Sorry, something went wrong.
|
@Trott I don't know if you want to run CI again to be safe. |
Sorry, something went wrong.
Now that we have backticks we no longer need to use util.format to template strings! This commit was inspired by #3324, and it replaces instances of util.format with backtick strings in a number of tests
|
There seem to be two files use const at the left side of require() method, but rest two files use var. |
Sorry, something went wrong.
|
I only updated the files that were obvious about what was going on with variable declaration. The other tests had instances where let made more sense and figure I'd rather not start dealing with that logic for this PR. More than happy to do this. |
Sorry, something went wrong.
Sorry, something went wrong.
|
LGTM if CI doesn't do anything unexpected |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
LGTM... will land in a sec |
Sorry, something went wrong.
Now that we have backticks we no longer need to use util.format to template strings! This commit was inspired by #3324, and it replaces instances of util.format with backtick strings in a number of tests Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #3359
|
Landed in 6c032a8 ... btw, @thealphanerd ... watch your line breaks in your commit messages. I fixed it up in the landed commit. |
Sorry, something went wrong.
|
if tests are being backported this should be considered for lts /cc @jasnell |
Sorry, something went wrong.
Now that we have backticks we no longer need to use util.format to template strings! This commit was inspired by #3324, and it replaces instances of util.format with backtick strings in a number of tests Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #3359
Now that we have backticks we no longer need to use util.format to template strings! This commit was inspired by #3324, and it replaces instances of util.format with backtick strings in a number of tests Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #3359
Now that we have backticks we no longer need to use util.format to template strings!
This commit was inspired by #3324, and it replaces instances of util.format with backtick strings in a number of tests
closes #3340 #3338 #3336