src: introduce TimerWrap/TimerWrapHandle utility - #34186
Closed
jasnell wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
reviewed
Jul 3, 2020
Comment thread
src/timer_wrap.cc
Outdated
Comment thread
src/timer_wrap.h
Outdated
Comment thread
src/node_perf.cc
Outdated
Comment thread
src/node_perf.h
Outdated
addaleax
approved these changes
Jul 3, 2020
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/32204/ (:yellow_heart:) |
Sorry, something went wrong.
32 tasks
mcollina
approved these changes
Jul 4, 2020
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
31 tasks
Consolidate uv_timer_t boilerplate code into a shared utility. There are several places throughout the code where we use uv_timer_t internally (inspector, perf, quic), with some code duplication. This eliminates the duplicated code, ensures that cleanup occurs correctly, and simplifies use of the timers. Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
added a commit
that referenced
this pull request
Jul 5, 2020
Consolidate uv_timer_t boilerplate code into a shared utility. There are several places throughout the code where we use uv_timer_t internally (inspector, perf, quic), with some code duplication. This eliminates the duplicated code, ensures that cleanup occurs correctly, and simplifies use of the timers. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #34186 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
added a commit
that referenced
this pull request
Jul 5, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #34186 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
added a commit
that referenced
this pull request
Jul 5, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #34186 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
This was referenced Jul 6, 2020
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jul 7, 2020
0f97d60 accidentally removed this. Refs: nodejs#34186
18 tasks
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Jul 8, 2020
0f97d60 accidentally removed this. Refs: nodejs#34186
20 tasks
17 tasks
This was referenced Jul 11, 2020
Copy link
Copy Markdown
Contributor
|
Marked as "backport-requested" because I do not believe quic is on 14.x yet. Should we change the label to "dont-land"? |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Consolidate uv_timer_t boilerplate code into a shared utility. There are several places throughout the code where we use uv_timer_t internally (inspector, perf, quic), with some code duplication. This eliminates the duplicated code, ensures that cleanup occurs correctly, and simplifies use of the timers. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #34186 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #34186 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 14, 2021
This was added in nodejs/node#34186 and nodejs/node#38172. Fix upstreamed at nodejs/node#38686.
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 14, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 18, 2021
This was added in nodejs/node#34186 and nodejs/node#38172. Fix upstreamed at nodejs/node#38686.
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several places throughout src/* make use of uv_timer_t internally (inspector, perf, quic, etc). These duplicate code. This introduces a new utility class to consolidate code and make it easier overall to work with internal uv_timer_t instances.
First commit adds the utility, subsequent commits update systems that use it.
The quic specific commit cannot be backported to 14.x, the rest of the commits are backportable.
Checklist