src: remove extra semi after member fn - #38686
Closed
codebytere wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
codebytere
force-pushed
the
remove-extra-semi
branch
from
af935fe to
d8e9367
Compare
May 14, 2021 12:01
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 14, 2021
This was added in nodejs/node#34186 and nodejs/node#38172. Fix upstreamed at nodejs/node#38686.
cjihrig
approved these changes
May 14, 2021
richardlau
approved these changes
May 14, 2021
RaisinTen
approved these changes
May 14, 2021
This comment has been minimized.
jasnell
approved these changes
May 14, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
juanarbol
approved these changes
May 14, 2021
Trott
approved these changes
May 16, 2021
codebytere
added a commit
that referenced
this pull request
May 16, 2021
PR-URL: #38686 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 17, 2021
PR-URL: #38686 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 18, 2021
This was added in nodejs/node#34186 and nodejs/node#38172. Fix upstreamed at nodejs/node#38686.
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 20, 2021
targos
pushed a commit
that referenced
this pull request
May 30, 2021
PR-URL: #38686 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 31, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 31, 2021
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #38686 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #38686 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 8, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 9, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 10, 2021
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #38686 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in #34186 and #38172 - causes build failures in Electron.
In file included from ../../third_party/electron_node/src/inspector_agent.cc:18: ../../third_party/electron_node/src/timer_wrap.h:35:23: error: extra ';' after member function definition [-Werror,-Wextra-semi] SET_NO_MEMORY_INFO(); ^ 1 error generated. [740/12750] CXX obj/cc/cc/layer_tree_host_impl.oIn file included from ../../third_party/electron_node/src/cares_wrap.cc:25: ../../third_party/electron_node/src/cares_wrap.h:144:37: error: extra ';' after member function definition [-Werror,-Wextra-semi] SET_MEMORY_INFO_NAME(NodeAresTask); ^ ../../third_party/electron_node/src/cares_wrap.h:145:30: error: extra ';' after member function definition [-Werror,-Wextra-semi] SET_SELF_SIZE(NodeAresTask); ^ 2 errors generated.