FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

quic: fixup `setSocket` support by jasnell · Pull Request #34669 · nodejs/node · GitHub

/ node Public

quic: fixup setSocket support - #34669

Closed
jasnell wants to merge 3 commits into
nodejs:masterfrom
jasnell:quic-cleanups-13
ConversationCommits (3)ChecksFiles changed
Closed

quic: fixup setSocket support#34669
jasnell wants to merge 3 commits into
nodejs:masterfrom
jasnell:quic-cleanups-13

Conversation

jasnell commented Aug 7, 2020

Copy link
Copy Markdown
Member

Ensures that migration to a new QuicSocket is working.

This depends on #34618 and #34655, both of which should land first. All but the final three commits in this PR are from those earlier PRs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

jasnell requested a review from a team August 7, 2020 19:30
nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 7, 2020
jasnell added dont-land-on-v14.x quic Issues and PRs related to the QUIC implementation / HTTP/3. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 7, 2020

nodejs-github-bot commented Aug 7, 2020 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32677/
QUIC CI: https://ci.nodejs.org/job/node-test-commit/40077/

jasnell added the review wanted PRs that need reviews. label Aug 10, 2020

nodejs-github-bot commented Aug 11, 2020 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32736/ 💚
QUIC CI: https://ci.nodejs.org/job/node-test-commit/40155/ 💚

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 11, 2020
This was referenced Aug 11, 2020
Closed
Closed

jasnell commented Aug 17, 2020

Copy link
Copy Markdown
Member Author

Landed in 344c5e4...c17eaa3

jasnell closed this Aug 17, 2020
jasnell added a commit that referenced this pull request Aug 17, 2020
quic: fixup set_socket, fix skipped test
10d5047 
PR-URL: #34669
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request Aug 17, 2020
quic: check setSocket natRebinding argument, extend test
442968c 
PR-URL: #34669
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request Aug 17, 2020
quic: add natRebinding argument to docs
c17eaa3 
PR-URL: #34669
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. quic Issues and PRs related to the QUIC implementation / HTTP/3. review wanted PRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL